fix: report why failfast cancelled a parallel task - #2954
Open
20ns wants to merge 1 commit into
Open
Conversation
When failfast stops sibling tasks, log which peer failed so the cancellation is visible instead of looking like a silent drop.
vmaerten
self-requested a review
August 4, 2026 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1226
When
failfastcancels a sibling task running in parallel, the cancellation was silent. This now reports which task caused the cancellation for both parallel calls and dependencies.Added regression coverage for both paths and updated the expected failfast output.
Verified with
go test . -run 'TestParallelFailfastCancellationReason|TestFailfast'and a local--parallel --failfastrun.Assisted with Cursor; I reviewed and tested the change.