fix: read result validity before Merge redeems it to the pool#260
Merged
Conversation
validateRequiredDefinitions read red.IsValid() *after* res.Merge(red). Merge redeems a result whose wantsRedeemOnMerge is set (true for any pool-borrowed result) back into the process-global sync.Pool. Reading red after that point races with a concurrent Spec() goroutine borrowing the same *Result and calling cleared() on it. This surfaced as a rare data race under -race in Test_ParallelPool: Write at ... Result.cleared() <- resultsPool.BorrowResult() Previous read ... Result.IsValid() <- validateRequiredDefinitions Capture validity into a local before merging, matching the read-before- merge pattern used everywhere else (e.g. validateRequiredProperties, default/example validators). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
fix/race-condition
branch
from
c4c4eb9 to
8dae61a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 92.41% 92.35% -0.06%
==========================================
Files 24 24
Lines 3271 3272 +1
==========================================
- Hits 3023 3022 -1
- Misses 163 165 +2
Partials 85 85 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateRequiredDefinitions read red.IsValid() after res.Merge(red). Merge redeems a result whose wantsRedeemOnMerge is set (true for any pool-borrowed result) back into the process-global sync.Pool. Reading red after that point races with a concurrent Spec() goroutine borrowing the same *Result and calling cleared() on it.
This surfaced as a rare data race under -race in Test_ParallelPool:
Write at ... Result.cleared() <- resultsPool.BorrowResult()
Previous read ... Result.IsValid() <- validateRequiredDefinitions
Capture validity into a local before merging, matching the read-before- merge pattern used everywhere else (e.g. validateRequiredProperties, default/example validators).
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist