test: stop executing the live remote-URL doc examples#259
Merged
Conversation
ExampleSpec_second and ExampleSpecValidator_Validate_url load a spec from http://petstore.swagger.io/v2/swagger.json, a live host that intermittently returns HTTP 403, making the suite flaky. Drop their "// Output:" directives so Go still compiles them (they remain in godoc with the real URL and cannot bit-rot) but no longer runs them under go test. The remote path exercises loads.JSONSpec + network rather than validate logic, which is already covered by the file-based examples and tests, so executed coverage is not lost. A note on each example explains why the directive is intentionally absent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExampleSpec_second and ExampleSpecValidator_Validate_url load a spec from http://petstore.swagger.io/v2/swagger.json, a live host that intermittently returns HTTP 403, making the suite flaky.
Drop their "// Output:" directives so Go still compiles them (they remain in godoc with the real URL and cannot bit-rot) but no longer runs them under go test. The remote path exercises loads.JSONSpec + network rather than validate logic, which is already covered by the file-based examples and tests, so executed coverage is not lost. A note on each example explains why the directive is intentionally absent.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist