Skip to content

Support blue yellow colorblind theme #35910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2025
Merged

Support blue yellow colorblind theme #35910

merged 4 commits into from
Nov 11, 2025
+58 −0

Conversation

@lutinglt
Copy link
Contributor

@lutinglt lutinglt commented Nov 10, 2025

This icon is from GitHub:

image

lutinglt and others added 2 commits November 10, 2025 12:22
@lutinglt
ThemeMetaInfo add support for blue-yellow colorblind theme
c92043b 
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>
@lutinglt
gitea-colorblind-blueyellow.svg
1e20fb5
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 10, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/frontend labels Nov 10, 2025
@lutinglt lutinglt marked this pull request as ready for review November 10, 2025 05:26
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 10, 2025

But there is no such theme support

@lutinglt
Copy link
Contributor Author

lutinglt commented Nov 10, 2025 •
edited
Loading

But there is no such theme support

Gitea GitHub Theme

My theme support blue yellow blindness, because I copied it from GitHub (😳

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 11, 2025

But there is no such theme support

Gitea GitHub Theme

My theme support blue yellow blindness, because I copied it from GitHub (😳

Can you add basic blue/yellow colorblind support to Gitea's theme (use GitHub's colors)? With basic official support, it would be easier for future work.

@lutinglt
Copy link
Contributor Author

lutinglt commented Nov 11, 2025

But there is no such theme support

Gitea GitHub Theme
My theme support blue yellow blindness, because I copied it from GitHub (😳

Can you add basic blue/yellow colorblind support to Gitea's theme (use GitHub's colors)? With basic official support, it would be easier for future work.

I've revised a version based on GitHub's logic. It seems quite straightforward—building upon the protanopia/deuteranopia theme and only reverting the color variables related to "remove" back to the normal theme's colors. 😄

@lutinglt lutinglt changed the title ThemeMetaInfo support blue yellow colorblind recognition Support blue yellow colorblind theme Nov 11, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 11, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 11, 2025
@lunny lunny added this to the 1.26.0 milestone Nov 11, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 11, 2025
@lunny lunny enabled auto-merge (squash) November 11, 2025 18:03
@lunny lunny merged commit 2223be2 into go-gitea:main Nov 11, 2025
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 11, 2025
@lutinglt lutinglt deleted the patch-1 branch November 12, 2025 02:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 12, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7597b53 
* giteaofficial/main:
  Support blue yellow colorblind theme (go-gitea#35910)
  Load jQuery as early as possible to support custom scripts (go-gitea#35926)
  Make OAuth2 issuer configurable (go-gitea#35915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lutinglt @wxiaoguang @lunny @GiteaBot