Permit update of Internal Status and MTU of network ports #22274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
removed Connection field status as it was not mentioned in the original issue (and test on GLPI gave me a doubt about my implementation), and add a number limitation on frontend-side, inspired by https://github.com/glpi-project/glpi/blob/11.0/bugfixes/templates/pages/setup/ldap/form.html.twig#L56 (dunno what is MTU tbh) |
Contributor
|
Is this one a draft or is it to review? |
AdrienClairembault
approved these changes
Dec 8, 2025
cedric-anne
approved these changes
Dec 8, 2025
|
|
||
| {{ fields.numberField('ifmtu', item.fields['ifmtu'], __('MTU'), { | ||
| min: 0, | ||
| max: 65535, |
Member
There was a problem hiding this comment.
This value will probably be lower than 10000, but I do not think it is required to set a maximum here, as some users may complain that it is a too low limit.
Suggested change
| max: 65535, |
cedric-anne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal for #21925
This PR add new fields on Network port form (added an extra field status that seems also logical to add)
Inputs values are based on source in
src/NetwortPort.php