Enable dynamic wave amplitude adjustments#36
Open
mhstoller wants to merge 3 commits intoglorylab:masterfrom
Open
Enable dynamic wave amplitude adjustments#36mhstoller wants to merge 3 commits intoglorylab:masterfrom
mhstoller wants to merge 3 commits intoglorylab:masterfrom
Conversation
This change allows the WaveWidget's waveAmplitude property to be updated dynamically (such as in a StreamBuilder) to change the amplitude on the fly
I haven't migrated my project to null safety so I was just kind of guessing what it wanted when a build error occured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the WaveWidget inside a StreamBuilder it wasn't possible to change the waveAmplitude value based on new stream data. This change allows you to update the waveAmplitude value and have it reflected in the waves that are displayed.
This may not be the best way to achieve this behavior, but if it's useful then great!
I also haven't migrated to null safety in my own project, so I don't know the implications of what I have done here, other than that it builds without errors.