application key support addon #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @ovidiul could you please run through the use case for your suggested changes here? It seems that it's aimed towards allowing this module to run with a single-bucket application key, rather than the master key. The latest version, 1.5.0, allows application keys by letting the dev specify the bucket id, thus removing the need to look up the bucket id by name, which requires the master key. I'm not sure what your suggested changes here do. Could you please explain it to me step-by-step? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that application key support integration is pretty simple, after normal authorisation, the B2 Api sends back the main accountId in the response header which we can use for the rest of the API requests that require the master account ID to be present, like the listBuckets api call.
Could you review this and let me know if we can integrated this inside the main package?