Stops open creating PRs from a branch to itself #4734
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4709
Description
In 8aefd7b we've started taking the base branch name for "Create PR" command from branch's settings, such as
gk-merge-base.However, frequently happens that this option is set to the branch itself, because our config follows the
vscode-merge-branch.It wasn't possible to check for the equality right in
CreatePullRequestOnRemoteCommandbecause on the next step we suggest user to choose a target remote. On different remotes it is possible to have same name branches on both sides of PR, we should cancel only when the PR happens within the same remote. That is why I perform that validation on a later step when both remotes have been defined.Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses