Skip to content

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Nov 7, 2025

fixes #4709

Description

In 8aefd7b we've started taking the base branch name for "Create PR" command from branch's settings, such as gk-merge-base.

However, frequently happens that this option is set to the branch itself, because our config follows the vscode-merge-branch.

It wasn't possible to check for the equality right in CreatePullRequestOnRemoteCommand because on the next step we suggest user to choose a target remote. On different remotes it is possible to have same name branches on both sides of PR, we should cancel only when the PR happens within the same remote. That is why I perform that validation on a later step when both remotes have been defined.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use merge target when creating pull requests

2 participants