Repository navigation
ci: guard CI dependency version compatibility - #3445
Merged
Merged
Conversation
setchy
changed the title
Renovate cannot keep the visual-regression Playwright container image in lockstep with the playwright devDependency: they are separate datasources with independent release timelines, and MCR exposes no release timestamp for minimumReleaseAge to compare. Grouping them still resolves to different versions and opens image-only PRs that strand the screenshot baselines (see #3437, #3299). Make package.json the source of truth and fail fast in Run Tests whenever the workflow image tag drifts from the devDependency.
Also assert the exact vitest/vite couplings CI depends on: @vitest/browser-playwright and @vitest/coverage-v8 peer on the vitest version that vite-plus bundles, and vite must resolve to the vite-plus-core build that vite-plus ships.
setchy
force-pushed
the
ci/playwright-image-lockstep
branch
from
October 16, 2026 22:21
a565ffa to
566a569
Compare
It tried to keep the npm package and the MCR image in lockstep, but Renovate can't compare the two release timelines (MCR exposes no release timestamp for minimumReleaseAge to read), so it never actually grouped them. The CI dependency compatibility test now guards the pairing.
|
Contributor
|
🎉 This pull request is included in Gitify v7.10.0! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Gitify better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI depends on a few version couplings that no single manifest expresses, and Renovate (or a manual edit) can move one half of a pair and leave the other behind. That surfaces as a confusing failure deep in the test or visual-regression run — most recently #3437, where the
playwrightnpm package was bumped but the pinned visual-regression container image was not (same manual fix as #3299).The couplings:
playwright(npm) must match themcr.microsoft.com/playwrightcontainer image tag — they ship the same browser build.@vitest/browser-playwrightand@vitest/coverage-v8peer-depend on the exactvitestversion.vite-plusbundlesvitestandvite(@voidzero-dev/vite-plus-core) at exact versions.Renovate can't keep the Playwright pair in lockstep on its own: they're separate datasources with independent release timelines, and MCR exposes no release timestamp for
minimumReleaseAgeto compare, so the image races ahead to the latest tag while npm waits out the age gate. Verified with local Renovate dry-runs.What
src/main/ciDependencyCompatibility.test.ts, asserting the couplings above against the versions actually installed. It runs in the Run Tests job, so drift fails fast and explicitly.renovate.json. It tried to keep the pair in lockstep but never actually grouped them (see above); the test now owns that guarantee.Tradeoff
The test is the guard: a Playwright upgrade needs the workflow tag + digest refreshed alongside the npm bump, and the test prints the exact
docker buildx imagetools inspectcommand to do it. If that ever becomes too manual, the alternative is to let Renovate manage the image and accept a PR that stays red across the 3-day release-age window until npm catches up.