Skip to content

feat: wire engine.version, engine.command, and engine.agent through to pipeline output#292

Closed
Copilot wants to merge 3 commits intomainfrom
copilot/wire-engine-version-command-agent
Closed

feat: wire engine.version, engine.command, and engine.agent through to pipeline output#292
Copilot wants to merge 3 commits intomainfrom
copilot/wire-engine-version-command-agent

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026 •
edited
Loading

The version, command, and agent fields on EngineOptions were parsed and stored but not wired into compiled pipeline output.

engine.version

Uses the specified version in the NuGet -Version flag. "latest" omits the flag entirely. Default falls back to COPILOT_CLI_VERSION constant.

engine:
  version: "1.2.3"   # pins NuGet install to this version
  # version: latest   # omits -Version flag, NuGet resolves latest

engine.command

Skips all NuGet install steps and uses the custom command path in AWF invocations. Validated: must be absolute path or bare binary name, no shell metacharacters or ...

engine:
  command: /usr/local/bin/my-copilot

engine.agent

Adds --agent <value> to Copilot CLI args. Validated: alphanumeric + hyphens only.

engine:
  agent: technical-doc-writer  # → --agent technical-doc-writer

Template changes

  • Replaced hardcoded NuGet install block and /tmp/awf-tools/copilot in both base.yml and 1es-base.yml with {{ engine_install_steps }} and {{ copilot_command }} markers
  • Added generate_install_steps() and generate_command_path() to the Engine trait, implemented for GitHubCopilotCliEngine
  • Exported COPILOT_CLI_VERSION from compile module for use by engine.rs
  • 35 new tests covering type accessors, CLI param generation, install step generation, command path validation, and security edge cases

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dev.azure.com
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 0.03l0815d29lj002ae3mmxfl3m.09jmos6.rcgu.o 0.0tn8ejcnvgjygdyylhtak9lpf.09jmos6.rcgu.o 0.0xx92o0xvmao3s3mmpaude4gm.09jmos6.rcgu.o 0.11wu39pl8x5unsfa0pm0sx7i8.09jmos6.rcgu.o 0.15ekd7s10qhmgvd15js1u58j5.09jmos6.rcgu.o 0.20695tlwm01eu06f6nytfaj15.09jmos6.rcgu.o 0.25dmyxexlbrf6s096aq9lq99g.09jmos6.rcgu.o 0.26zkdc197kx7li1nwob9t5xj9.09jmos6.rcgu.o 0.2cvf4nkhwgdzrg6bb0j1g45xz.09jmos6.rcgu.o 0.2figln0c2pfqzi2e08i006o8u.09jmos6.rcgu.o 0.2fla2kplyo8fcs0of160c962a.09jmos6.rcgu.o 0.2ikaohql56ne0w9lfnxyhwv2k.09jmos6.rcgu.o 0.2oqlsydd3dffl94jckwj4qblh.09jmos6.rcgu.o 0.2pfydlp0bjr74wlj1t3r6ms18.09jmos6.rcgu.o (dns block)
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 s/compiler_testsremote s/compiler_testsget-url s/compiler_testsorigin s/co�� s/compiler_tests-a8a48394b293b055.2paser1vd5pxuz2w3u0a448kf.1mp3yc7.rcgu.o s/compiler_tests-a8a48394b293b055.2rbeu1s9c2kkg745lgrt6daj2.1mp3yc7.rcgu.o de/node/bin/cc target/debug/dep/home/REDACTED/work/ado-aw/ado-aw/target/debug/ado-aw target/debug/depinit target/debug/dep--path target/debug/dep/tmp/.tmpBuJ8rd targ�� target/debug/deps/rustcxHIxNu/symbols.o target/debug/deps/compiler_tests-a8a48394b293b055.00l282qg8pqjpribuxk00ly57.1mp3yc7.rcgu.o target/debug/deps/compiler_tests-a8a48394b293b055.04pvr3v3jq5s9cz4rxzmhqadv.1mp3yc7.rcgu.o target/debug/depbash target/debug/dep--norc target/debug/dep--noprofile target/debug/deps/compiler_testsorigin (dns block)
    • Triggering command: `/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-c05a54f0ee13c0b7 4u8.1m8muhs.rcguremote x8k.1m8muhs.rcguget-url f8y.1m8muhs.rcguorigin uxb.�� dyk.1m8muhs.rcgu.o output

Agent-Logs-Url: REDACTED z3v.1m8muhs.rcgu.o 3i7.1m8muhs.rcgugit z5n.1m8muhs.rcguremote vgr.1m8muhs.rcguget-url zzx.1m8muhs.rcguorigin heq.�� exb.1m8muhs.rcgu.o 0ag.1m8muhs.rcgu.o k/_temp/ghcca-node/node/bin/git ob8.1m8muhs.rcgugit gbt.1m8muhs.rcguls-files --crate-type git` (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue Apr 21, 2026 that may be closed by this pull request
feat: wire engine.version, engine.command, and engine.agent through to pipeline output #288
Open
Copilot AI and others added 2 commits April 21, 2026 21:32
@jamesadevine
feat: wire engine.version, engine.command, and engine.agent through t…
a46eda4 
…o pipeline output

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/64a76476-e26a-4be4-8120-8eb469a0ef35

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
@jamesadevine
test: add tests for engine.version, engine.command, and engine.agent
008289f 
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/64a76476-e26a-4be4-8120-8eb469a0ef35

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot AI changed the title [WIP] Wire engine.version, engine.command, and engine.agent through to pipeline output feat: wire engine.version, engine.command, and engine.agent through to pipeline output Apr 21, 2026
Copilot AI requested a review from jamesadevine April 21, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesadevine jamesadevine Awaiting requested review from jamesadevine

Assignees

@jamesadevine jamesadevine

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: wire engine.version, engine.command, and engine.agent through to pipeline output

2 participants

@jamesadevine