Repository navigation
refactor: reduce complexity of resolve_spec in compile/imports/mod.rs - #2403
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_specwas 146 lines (clippytoo_many_lines146/100) because it handled both local and remote imports inline.It now dispatches to two helpers,
resolve_local_specandresolve_remote_spec. The bodies moved over unchanged, so behaviour is the same.resolve_specis no longer flagged bytoo_many_lines.Validation:
cargo build: passedcargo test imports: passed (60 tests in the main test binary, plus the other test targets, all passing)cargo clippy --all-targets --all-features -- -W clippy::too_many_lines:resolve_specno longer flagged.resolve_imports_with_repo_rootat line 686 is still flagged; that is a separate function and was not changed.I did not run the full
cargo testsuite.