docs: fix conclusion job token reference and create-prompt field list - #1690
Draft
github-actions[bot] wants to merge 1 commit into
Draft
docs: fix conclusion job token reference and create-prompt field list#1690github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
- docs/conclusion.md: line 94 said only SYSTEM_ACCESSTOKEN but after fix #1689 the Conclusion job also acquires SC_WRITE_TOKEN when permissions.write is configured; make it consistent with lines 113-118 - prompts/create-ado-agentic-workflow.md: add execution-context, variable-groups, post-steps, and env to the optional front-matter fields list so agents know these keys exist when authoring workflows Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Documentation Update
Findings
docs/conclusion.mdline 94 said the Conclusion job uses onlySYSTEM_ACCESSTOKEN, but fix #1689 addedSC_WRITE_TOKENacquisition to the Conclusion job whenpermissions.writeis configured. This contradicted lines 113–118 on the same page and the actual compiled output.docs/conclusion.mdprompts/create-ado-agentic-workflow.mdoptional fields list was missingpost-steps,execution-context,variable-groups, andenv— all validFrontMatterfields verified insrc/compile/types.rs. Agents authoring new workflows would be unaware these keys exist.prompts/create-ado-agentic-workflow.mdApplied Fixes
docs/conclusion.mdline 94: updated "usingSYSTEM_ACCESSTOKEN" → "usingSYSTEM_ACCESSTOKEN(orSC_WRITE_TOKENwhen a write service connection is configured)" — consistent with lines 113–118 and thebuild_conclusion_jobcode insrc/compile/agentic_pipeline.rsprompts/create-ado-agentic-workflow.md: addedpost-steps,execution-context,variable-groups, andenvto the optional front-matter fields listNotes
src/compile/agentic_pipeline.rs::build_conclusion_job(lines 1802–1803), which callspush_raw_yaml_if_nonempty(&mut steps, &cfg.acquire_write_token)— the same acquire-token step used by SafeOutputs.pub struct FrontMatterinsrc/compile/types.rs(lines 1048–1178).Created by the agent-documentation maintainer workflow.