refactor(ir): reduce complexity of add_edges_from_job in graph.rs - #1683
Draft
github-actions[bot] wants to merge 1 commit into
Draft
refactor(ir): reduce complexity of add_edges_from_job in graph.rs#1683github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Extract add_edges_for_condition and add_edges_for_env helpers to
eliminate the repeated for-ref-loop pattern inside every Step arm.
Before: 52 lines, 4 nested levels, each of 4 step variants repeated
the same collect→loop→add_edge_for_ref pattern inline.
After: 30-line match delegating to two focused helpers; each match
arm is ≤2 lines.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_edges_from_jobinsrc/compile/ir/graph.rsrepeated the samecollect→for→add_edge_for_refpattern inline inside every match arm,creating 4 levels of nesting and making the intent hard to read.
What changed
Extracted two focused private helpers:
add_edges_for_condition— takes anOption<&Condition>and addsgraph edges for all
OutputRefs found inside it.add_edges_for_env— takes an iterator of&EnvValueand addsgraph edges for all
StepOutputreferences.add_edges_from_jobnow delegates to these helpers; each match arm is≤ 2 lines.
Before / After
add_edges_from_jobVerification
cargo test— all tests passcargo clippy --all-targets --all-features— cleanWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comSee Network Configuration for more information.