Repository navigation
fix(agent-context): skip non-file plan candidates - #5222
Open
WOLIKIMCHENG wants to merge 2 commits into
Open
WOLIKIMCHENG wants to merge 2 commits into
WOLIKIMCHENG wants to merge 2 commits into
Conversation
Assisted-by: Codex CLI (model: gpt-6.1-sol, autonomous)
mnriem
added
the
triage-must-have
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the modification-time fallback change.
No open issues 🎉
What changed in this PR
Fixes the bundled agent-context extension’s modification-time fallback so non-file plan.md candidates are ignored while valid in-project file links and existing selection priority are preserved.
Changes:
- Adds matching file-type checks to the Python and Bash resolvers without suppressing unrelated stat errors.
- Adds regression coverage for directories, symlinks, containment, and filesystem errors.
- Bumps agent-context to
1.0.3and updates the catalog and example bundle pins.
| File | Description |
|---|---|
tests/extensions/test_update_agent_context_python_parity.py |
Adds candidate-filtering and error-handling tests; normalizes Bash script paths. |
extensions/catalog.json |
Updates the agent-context version to 1.0.3. |
extensions/agent-context/scripts/python/update_agent_context.py |
Filters non-file candidates from the mtime fallback. |
extensions/agent-context/scripts/bash/update-agent-context.sh |
Applies matching filtering in the embedded Python fallback. |
extensions/agent-context/extension.yml |
Bumps the extension patch version. |
examples/bundles/security-researcher/bundle.yml |
Pins agent-context to 1.0.3. |
examples/bundles/product-manager/bundle.yml |
Pins agent-context to 1.0.3. |
examples/bundles/developer/bundle.yml |
Pins agent-context to 1.0.3. |
examples/bundles/business-analyst/bundle.yml |
Pins agent-context to 1.0.3. |
Review effort: Balanced (auto)
Collaborator
|
Please fix test & lint errors |
Assisted-by: Codex CLI (model: gpt-6.1-sol, autonomous)
Contributor
Author
|
Review-round update for commit
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
plan.mdcandidates in the agent-context mtime fallback.1.0.3in its manifest and catalog; retain upstream removal of obsolete example bundles.Testing
uvx ruff@0.15.0 check src testsand the extension version guard: passed.AI Disclosure
AI disclosure: AI-assisted tools were used to implement the fix and develop tests.