fix: narrow exception in Content-Length header lookup from Exception to AttributeError - #3918
Open
Quratulain-bilal wants to merge 1 commit into
Open
Conversation
…to AttributeError Bare 'except Exception' would swallow MemoryError, RecursionError, etc. The only realistic failure from getheader() is AttributeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bare
except Exceptionwould swallowMemoryError,RecursionError, etc.Fix
Narrow to
AttributeErrorwhich is the only realistic failure fromgetheader().Testing
Verified Content-Length header is read correctly
Verified missing header is handled gracefully