fix: enforce size limit on local workflow YAML files - #3906
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: enforce size limit on local workflow YAML files#3906Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
The codebase defines _MAX_WORKFLOW_YAML_BYTES (5 MiB) and enforces it on HTTP-downloaded workflows, but local YAML files read via _validate_and_install_local() had no size guard. A user or script pointing 'specify workflow install' at an arbitrarily large local file could cause unbounded memory allocation. Apply the same limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The codebase defines
_MAX_WORKFLOW_YAML_BYTES(5 MiB) and enforces it on HTTP-downloaded workflows, but local YAML files read via_validate_and_install_local()had no size guard. A user or script pointingspecify workflow installat an arbitrarily large local file could cause unbounded memory allocation.Fix
Apply the same 5 MiB limit to local workflow YAML files.
Testing
Verified normal workflow files install correctly
Verified oversized files are rejected with a clear error message