Skip to content

fix(kimi): preserve non-UTF-8 user skills #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcelsafin wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −1
Open

fix(kimi): preserve non-UTF-8 user skills #3895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/specify_cli/integrations/kimi/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ def _is_speckit_generated_skill(skill_dir: Path) -> bool:

try:
content = skill_file.read_text(encoding="utf-8")
except OSError:
except (OSError, UnicodeError):
return False

if not content.startswith("---"):
Expand Down
18 changes: 18 additions & 0 deletions tests/integrations/test_integration_kimi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,24 @@ def test_teardown_preserves_user_skills_in_legacy_dir(self, tmp_path):

assert user_skill.exists()

def test_teardown_preserves_non_utf8_user_skill(self, tmp_path):
i = get_integration("kimi")

user_skill = (
tmp_path
/ ".kimi"
/ "skills"
/ "speckit-user-owned"
/ "SKILL.md"
)
user_skill.parent.mkdir(parents=True)
user_skill.write_bytes(b"\xff\xfe")

m = IntegrationManifest("kimi", tmp_path)
i.teardown(tmp_path, m)

assert user_skill.read_bytes() == b"\xff\xfe"


class TestKimiCommandInvocation:
"""Kimi dispatch must use the native ``/skill:`` slash command."""
Expand Down