Restore NODE_AUTH_TOKEN for GitHub Packages publish#357
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a release regression in the GitHub Actions publish workflow by restoring authentication for publishing to GitHub Packages (npm.pkg.github.com) in the publish-github job.
Changes:
- Re-adds
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}to the GitHub Packagesnpm publishstep to prevent401 Unauthorizedfailures.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Restores NODE_AUTH_TOKEN on the GitHub Packages publish step so npm publish can authenticate to npm.pkg.github.com. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
joshblack
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publish-githubjob inpublish.ymlfailed during the v5.1.0 release with401 Unauthorizedwhen pushing tonpm.pkg.github.com:This is a regression from a8c32fc, which added
id-token: writeto the GPR job and removedNODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}from the publish step.That change appears to mirror the OIDC trusted-publisher flow we use for npmjs.org, but
npm.pkg.github.comstill requiresNODE_AUTH_TOKENto authenticate the publish.This PR restores
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}on the GPR publish step.