Install Playwright browsers in publish workflow#356
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release publish workflow to ensure Playwright’s Chromium browser binary is installed on the GitHub Actions runner before running npm test, aligning it with the existing CI workflow behavior and preventing release-time publish failures.
Changes:
- Install Playwright Chromium (and required OS deps) prior to running tests in the npm publish job.
- Install Playwright Chromium (and required OS deps) prior to running tests in the GitHub Packages publish job.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Adds npx playwright install --with-deps chromium before npm test in both publish jobs to prevent missing-browser test failures during releases. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
joshblack
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow fails on
npm testbecause Playwright's Chromium binary isn't available on the runner:Failed workflow run: https://github.com/github/relative-time-element/actions/runs/27169511742