Skip to content

Simplify npm publish step in workflow#32

Open
gracepark wants to merge 1 commit intomainfrom
gracepark-patch-1
Open

Simplify npm publish step in workflow#32
gracepark wants to merge 1 commit intomainfrom
gracepark-patch-1

Conversation

@gracepark
Copy link
Copy Markdown
Contributor

Part of: https://github.com/github/web-systems/issues/4309

OIDC migration. Removed npm whoami command from the publish workflow.

Removed npm whoami command from the publish workflow.
Copilot AI review requested due to automatic review settings May 8, 2026 20:10
@gracepark gracepark requested a review from a team as a code owner May 8, 2026 20:10
@gracepark gracepark requested a review from bteng22 May 8, 2026 20:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release publishing workflow to align with an npm OIDC/Trusted Publishing flow by removing the preliminary identity check and publishing without a stored npm token.

Changes:

  • Removes the npm whoami pre-check from the publish job.
  • Stops injecting NODE_AUTH_TOKEN and runs npm publish --provenance directly.
Show a summary per file
File Description
.github/workflows/publish.yml Simplifies the npm publish step and removes token-based auth in favor of OIDC-based publishing.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

@@ -24,6 +24,4 @@ jobs:
- run: npm version ${TAG_NAME} --git-tag-version=false
env:
TAG_NAME: ${{ github.event.release.tag_name }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants