Skip to content

fix(deps): bump nokogiri to >= 1.19.1 to fix GHSA-wx95-c6cv-8532 #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zkoppert merged 2 commits into from
Mar 10, 2026
+9 −10
Merged

fix(deps): bump nokogiri to >= 1.19.1 to fix GHSA-wx95-c6cv-8532 #2031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
244f19b
fix(deps): bump nokogiri to >= 1.19.1 to fix GHSA-wx95-c6cv-8532
zkoppert Mar 10, 2026
aef5252
ci: drop Ruby 3.1 from test matrix (EOL since March 2025)
zkoppert Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
strategy:
matrix:
ruby:
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI no longer tests Ruby 3.1, but the gemspec still declares required_ruby_version '>= 3.1.0' (github-markup.gemspec:16). Either update required_ruby_version to match the supported/tested range, or keep 3.1 in the matrix if it remains supported.

Suggested change
ruby:
ruby:
- "3.1"

Copilot uses AI. Check for mistakes.
- "3.1"
- "3.2"
- "3.3"
- "3.4"
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ gem "twitter-text", "~> 1.14"
gem "asciidoctor", "~> 2.0.5"
gem "rake"
gem "rexml"
gem "nokogiri", "~> 1.18.9"
gem "nokogiri", ">= 1.19.1"
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemfile now requires nokogiri >= 1.19.1, but the gemspec still declares a development dependency constraint of nokogiri '~> 1.18.4' (github-markup.gemspec:28). Having two conflicting sources of truth is error-prone (and can cause Bundler resolution failures depending on how dependencies are evaluated). Align the gemspec constraint with the new minimum version (or remove the gemspec entry if Gemfile is the intended source).

This issue also appears on line 18 of the same file.

Suggested change
gem "nokogiri", ">= 1.19.1"
gem "nokogiri", "~> 1.18.4"

Copilot uses AI. Check for mistakes.
16 changes: 8 additions & 8 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,18 @@ GEM
mini_portile2 (2.8.9)
minitest (5.25.5)
mutex_m (0.3.0)
nokogiri (1.18.9)
nokogiri (1.19.1)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.18.9-aarch64-linux-gnu)
nokogiri (1.19.1-aarch64-linux-gnu)
racc (~> 1.4)
nokogiri (1.18.9-arm-linux-gnu)
nokogiri (1.19.1-arm-linux-gnu)
racc (~> 1.4)
nokogiri (1.18.9-arm64-darwin)
nokogiri (1.19.1-arm64-darwin)
racc (~> 1.4)
nokogiri (1.18.9-x86_64-darwin)
nokogiri (1.19.1-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.18.9-x86_64-linux-gnu)
nokogiri (1.19.1-x86_64-linux-gnu)
racc (~> 1.4)
nokogiri-diff (0.3.0)
nokogiri (~> 1.5)
Expand Down Expand Up @@ -128,7 +128,7 @@ DEPENDENCIES
html-pipeline (~> 1.0)
kramdown
minitest (~> 5.4, >= 5.4.3)
nokogiri (~> 1.18.9)
nokogiri (>= 1.19.1)
nokogiri-diff (~> 0.3.0)
org-ruby (= 0.9.12)
rake
Expand All @@ -140,4 +140,4 @@ DEPENDENCIES
wikicloth (= 0.8.3)

BUNDLED WITH
2.5.9
2.4.10
Loading