Repository navigation
Respect form fields inside open shadow roots - #158
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the original composed-path target when checking form fields and scoped hotkeys, following the approach discussed in #123. Typing inside an open shadow root no longer activates global shortcuts; closed roots retain their existing behavior.
Added nine regression cases covering editable controls, nested roots, matching and mismatched scopes, and non-editable controls. All pass in Chromium, Firefox, and WebKit. Lint, type checking, and the build pass. The full browser suites have one existing macOS Meta+Shift failure per engine, reproduced on untouched
main(297 passed / 3 failed before, 324 passed / 3 failed after).Fixes #123.