Repository navigation
Reject list_label perPage values outside 1..100 - #3649
Open
vshalpnjabi wants to merge 1 commit into
Open
vshalpnjabi wants to merge 1 commit into
vshalpnjabi wants to merge 1 commit into
Conversation
cursor
Bot
force-pushed
the
fix-list-label-perpage-zero
branch
from
November 2, 2026 22:37
6f56a99 to
c11d716
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_labelnow rejectsperPagevalues outside 1..100 instead of passing 0 through.Why
The advertised schema says
minimum: 1, but the runtime input schema doesn't enforce it, soperPage: 0reached the handler and was silently replaced with the default page size.Fixes #3647
What changed
listLabelsLegacyreadsperPageonly when it's present and returnsperPage must be between 1 and 100, got Nwhen it's out of range. The default still applies when it's omitted.perPage: 0and updated the >100 case to the new message.TestListLabelPerPageZeroThroughToolCall, which calls the registered tool through an MCP session and asserts the error and that no GraphQL request is made. It fails onmain.MCP impact
list_labelreturns a tool error forperPage0 or below, matching the schema it already advertises. The schema is unchanged.Prompts tested (tool changes only)
Security / limits
Tool renaming
Lint & tests
./script/lint./script/testAlso ran
go test -v ./...,UPDATE_TOOLSNAPS=true go test ./...(no snapshot changes) andscript/generate-docs(no diff).Docs