Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/feature-flags.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ runtime behavior (such as output formatting) won't appear here.

- **update_issue_type** - Update Issue Type
- **Required OAuth Scopes**: `repo`
- `confidence`: How confident you are in this choice (0–100). 90–100: very high — clear signal or explicit user request. 70–89: high — strong signals, likely correct. 50–69: moderate — reasonable inference but ambiguous. 30–49: low — best guess, user review recommended. 0–29: very low — speculative. (number, optional)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the value of adding these range categories?
They seem somewhat arbitrary and don't actually exist anywhere in the code.
We could think about the confidence be something like an enum (with values mapped to named categories), but since we're using a numeric range, simply overlaying arbitrary ranges (which aren't enforced/referenced anywhere in the code) doesn't seem like it makes a lot of sense

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that we will have the same buckets as a guide for maintainers when setting the thresholds. I'm afraid that without any guidance it would be totally unpredictable. Do you think using an enum instead would be better?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think so. i don't really see a reason to care about a difference between a confidence value of 74 vs 76...
I think a few (named) categories would make more sense.
we could keep the 0-100 range on the backend, and use categories in all of the API/UI endpoints (which we would translate to a 0-100 number). That way we can add more fine-grained categories later if we want.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this on Slack and decided to go ahead with this configuration for experimentation for now. We can always change it in the future.

- `is_suggestion`: If true, this issue type change is sent to the API as a suggestion (suggest:true) rather than an applied value. Whether the type is applied or recorded as a proposal is determined by the API. (boolean, optional)
- `issue_number`: The issue number to update (number, required)
- `issue_type`: The issue type to set (string, required)
Expand Down Expand Up @@ -240,7 +241,7 @@ runtime behavior (such as output formatting) won't appear here.
- `owner`: Repository owner (username or organization) (string, required)
- `pullNumber`: The pull request number (number, required)
- `repo`: Repository name (string, required)
- `reviewers`: GitHub usernames to request reviews from (string[], required)
- `reviewers`: GitHub usernames or ORG/team-slug team reviewers to request reviews from (string[], required)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to come from an unrelated change that probably didn't update the docs


- **resolve_review_thread** - Resolve Review Thread
- **Required OAuth Scopes**: `repo`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@
"type": "object"
},
"name": "request_pull_request_reviewers"
}
}
8 changes: 7 additions & 1 deletion pkg/github/__toolsnaps__/set_issue_fields.snap
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,19 @@
"openWorldHint": true,
"title": "Set Issue Fields"
},
"description": "Set issue field values for an issue. Fields are organization-level custom fields (text, number, date, or single select). Use this to create or update field values on an issue.",
"description": "Set issue field values for an issue. Fields are organization-level custom fields (text, number, date, or single select). Use this to create or update field values on an issue. When setting values, include a confidence score (0–100) reflecting how certain you are about the choice.",
"inputSchema": {
"properties": {
"fields": {
"description": "Array of issue field values to set. Each element must have a 'field_id' (string, the GraphQL node ID of the field) and exactly one value field: 'text_value' for text fields, 'number_value' for number fields, 'date_value' (ISO 8601 date string) for date fields, or 'single_select_option_id' (the GraphQL node ID of the option) for single select fields. Set 'delete' to true to remove a field value.",
"items": {
"properties": {
"confidence": {
"description": "How confident you are in this choice (0–100). 90–100: very high — clear signal or explicit user request. 70–89: high — strong signals, likely correct. 50–69: moderate — reasonable inference but ambiguous. 30–49: low — best guess, user review recommended. 0–29: very low — speculative.",
"maximum": 100,
"minimum": 0,
"type": "integer"
},
"date_value": {
"description": "The value to set for a date field (ISO 8601 date string)",
"type": "string"
Expand Down
8 changes: 7 additions & 1 deletion pkg/github/__toolsnaps__/update_issue_labels.snap
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"openWorldHint": true,
"title": "Update Issue Labels"
},
"description": "Update the labels of an existing issue. This replaces the current labels with the provided list.",
"description": "Update the labels of an existing issue. This replaces the current labels with the provided list. When setting values, include a confidence score (0–100) reflecting how certain you are about the choice.",
"inputSchema": {
"properties": {
"issue_number": {
Expand All @@ -22,6 +22,12 @@
},
{
"properties": {
"confidence": {
"description": "How confident you are in this choice (0–100). 90–100: very high — clear signal or explicit user request. 70–89: high — strong signals, likely correct. 50–69: moderate — reasonable inference but ambiguous. 30–49: low — best guess, user review recommended. 0–29: very low — speculative.",
"maximum": 100,
"minimum": 0,
"type": "integer"
},
"is_suggestion": {
"description": "If true, this label is sent to the API as a suggestion (suggest:true) rather than an applied label. Whether the label is applied or recorded as a proposal is determined by the API.",
"type": "boolean"
Expand Down
8 changes: 7 additions & 1 deletion pkg/github/__toolsnaps__/update_issue_type.snap
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,15 @@
"openWorldHint": true,
"title": "Update Issue Type"
},
"description": "Update the type of an existing issue (e.g. 'bug', 'feature').",
"description": "Update the type of an existing issue (e.g. 'bug', 'feature'). When setting values, include a confidence score (0–100) reflecting how certain you are about the choice.",
"inputSchema": {
"properties": {
"confidence": {
"description": "How confident you are in this choice (0–100). 90–100: very high — clear signal or explicit user request. 70–89: high — strong signals, likely correct. 50–69: moderate — reasonable inference but ambiguous. 30–49: low — best guess, user review recommended. 0–29: very low — speculative.",
"maximum": 100,
"minimum": 0,
"type": "integer"
},
"is_suggestion": {
"description": "If true, this issue type change is sent to the API as a suggestion (suggest:true) rather than an applied value. Whether the type is applied or recorded as a proposal is determined by the API.",
"type": "boolean"
Expand Down
2 changes: 1 addition & 1 deletion pkg/github/__toolsnaps__/update_pull_request.snap
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,4 @@
"type": "object"
},
"name": "update_pull_request"
}
}
Loading
Loading