Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/bc6a401e-2259-4f85-8bbe-d12a874adbf8 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 18, 2026 20:37
View session
pelikhan
approved these changes
Apr 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes a flaky pkg/cli unit test by avoiding an include path that could trigger real GitHub fetching / auth prompts, while keeping coverage focused on #section fragment extraction.
Changes:
- Updated
TestFetchIncludeFromSource_SectionExtractionto use a non-fetching include path for the@ref#sectioncase. - Clarified the subtest comment to reflect that unit tests expect resolution errors while still validating fragment extraction.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/remote_workflow_test.go |
Adjusts section-extraction test input/comment to avoid unintended remote fetch behavior that can hang in CI. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make agent-finishwas intermittently timing out due to apkg/cliunit test path that unintentionally triggered remote include resolution and blocked on GitHub credential prompts. The timeout originated in section-extraction coverage, not section parsing logic itself.Problem-focused adjustment (test input only)
TestFetchIncludeFromSource_SectionExtractioninpkg/cli/remote_workflow_test.goto use a non-workflowspec include path for the@ref#sectioncase.Clarity cleanup