-
Notifications
You must be signed in to change notification settings - Fork 169
Fix label trigger schema validation for pull_request events #15321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pelikhan
merged 5 commits into
main
from
copilot/fix-github-actions-workflow-cee0e0c7-a22a-4a12-933e-4d9562db4fbf
Feb 13, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
088f054
Initial plan
Copilot cf03d61
Fix label trigger schema validation for pull_request events
Copilot 608919d
Update label trigger tests for different event types
Copilot feb7bc2
Use switch statement for entityType (lint fix)
Copilot 59b60f4
Merge branch 'main' into copilot/fix-github-actions-workflow-cee0e0c7…
pelikhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,8 +79,8 @@ func parseLabelTriggerShorthand(input string) (entityType string, labelNames []s | |
|
|
||
| // expandLabelTriggerShorthand takes an entity type and label names and returns a map that represents | ||
| // the expanded label trigger + workflow_dispatch configuration with item_number input. | ||
| // Note: For discussion events, GitHub Actions doesn't support the `names` field, | ||
| // so we use the native label filter marker but the names will be filtered via job conditions. | ||
| // Note: For discussion events, GitHub Actions doesn't support the `labels` field, | ||
| // so we use the native label filter marker but the labels will be filtered via job conditions. | ||
| func expandLabelTriggerShorthand(entityType string, labelNames []string) map[string]any { | ||
| // Create the trigger configuration based on entity type | ||
| var triggerKey string | ||
|
|
@@ -104,11 +104,19 @@ func expandLabelTriggerShorthand(entityType string, labelNames []string) map[str | |
| "types": []any{"labeled"}, | ||
| } | ||
|
|
||
| // Only add names field for issues and pull_request (GitHub Actions supports it) | ||
| // For discussions, names field is not supported by GitHub Actions | ||
| if entityType == "issues" || entityType == "pull_request" { | ||
| // Add label names for filtering | ||
| // For issues: GitHub Actions supports native `labels` field - use it with marker | ||
| // For pull_request & discussion: Use `names` field for job condition filtering (no marker) | ||
| // Note: The `names` field is an internal representation for job condition generation | ||
| // and won't be rendered in the final GitHub Actions YAML for these event types | ||
| switch entityType { | ||
| case "issues": | ||
| triggerConfig["labels"] = labelNames | ||
| triggerConfig["__gh_aw_native_label_filter__"] = true // Marker to use native filtering | ||
| case "pull_request", "discussion": | ||
| // For pull_request and discussion: add names field for job condition filtering | ||
| triggerConfig["names"] = labelNames | ||
| triggerConfig["__gh_aw_native_label_filter__"] = true // Marker to prevent commenting out names | ||
| // No marker - this will be filtered via job conditions | ||
| } | ||
|
Comment on lines
+112
to
120
|
||
|
|
||
| // Create workflow_dispatch with item_number input | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation changes removing details about GitHub App per-job token narrowing and auto-revocation appear to be unrelated to the label trigger fix described in the PR description. This creates inconsistency because:
docs/src/content/docs/reference/safe-outputs.md(lines 1372-1383)docs/src/content/docs/reference/tokens.mdxfile still references this per-job narrowing behaviorEither these changes should be:
This issue also appears on line 3437 of the same file.