Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 13, 2026

The jsweep commit introduced formatting inconsistencies in merge_remote_agent_github_folder.cjs that failed CI linting checks.

Changes

  • Standardized quote style: Changed single quotes to double quotes for string literals ('\0'"\0", '..'"..")
  • Removed trailing whitespace: Cleaned up line endings in validateSafePath() and mergeGithubFolder() functions

The original validate_memory_files.cjs cleanup was already properly formatted and all 21 tests pass.

- if (userPath.includes('\0')) {
+ if (userPath.includes("\0")) {
    throw new Error(`Invalid ${name}: contains null bytes`);
  }
-  
+
  // Reject paths that attempt to traverse up (..)
- if (userPath.includes('..')) {
+ if (userPath.includes("..")) {
    throw new Error(`Invalid ${name}: path traversal detected`);
  }

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Clean validate_memory_files.cjs Fix JavaScript formatting in merge_remote_agent_github_folder.cjs Feb 13, 2026
Copilot AI requested a review from pelikhan February 13, 2026 07:01
@pelikhan pelikhan marked this pull request as ready for review February 13, 2026 07:02
Copilot AI review requested due to automatic review settings February 13, 2026 07:02
@pelikhan pelikhan merged commit bd027bf into main-4e38aad7759d2e5d Feb 13, 2026
4 checks passed
@pelikhan pelikhan deleted the copilot/sub-pr-15313 branch February 13, 2026 07:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes JavaScript formatting inconsistencies in merge_remote_agent_github_folder.cjs that were introduced by a previous jsweep commit and failed CI linting checks. The changes align the code with the project's Prettier configuration, which specifies double quotes for .cjs files.

Changes:

  • Standardized string literals to use double quotes ('\0'"\0", '..'"..")
  • Removed trailing whitespace from several blank lines in the file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pelikhan pushed a commit that referenced this pull request Feb 13, 2026
* Clean validate_memory_files.cjs - modernize code with arrow functions and optional chaining

* Fix JavaScript formatting in merge_remote_agent_github_folder.cjs (#15316)

* Merge main branch and resolve conflicts in validate_memory_files.cjs (#15319)

* Add refiner workflow for automated code style and security analysis (#15307)

* test: avoid flaky readonly dir assertion in extractZipFile (#15312)

* docs: add unassign-from-user safe output documentation (#15310)

* Fix TypeScript type errors in error handling for unknown types (#15308)

* Initial plan

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Mark L <73659136+liuxiaopai-ai@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: JSweep Bot <jsweep-bot@github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Mark L <73659136+liuxiaopai-ai@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants