[Repo Assist] refactor: remove deprecated API key alias functions

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

PR #7114 renamed the gateway's "API key" surface to "Agent ID" but left four deprecated one-liner wrapper functions in place as backwards-compat aliases. These create IDE confusion (autocomplete surfaces the old names) and an ongoing maintenance burden. This PR removes them.

Changes

Location	Change
internal/auth/header.go	Remove ValidateAPIKey() deprecated alias; rename GenerateRandomAPIKey() → GenerateRandomAgentID()
internal/auth/header_test.go	Remove TestValidateAPIKeyAlias (tests a now-deleted function)
internal/auth/apikey_test.go	Rename all test functions and call sites to GenerateRandomAgentID
internal/cmd/root.go	Update the single production caller to use GenerateRandomAgentID()
internal/config/config_core.go	Remove GetAPIKey() deprecated alias (no non-definition callers)
internal/config/config_env.go	Remove GetGatewayAPIKeyFromEnv() deprecated alias (no non-definition callers)
internal/server/middleware.go	Update stale ValidateAPIKey() reference in doc comment

Verification

Confirmed no remaining references to the removed/renamed symbols via grep across the full source tree.

Test Status

Build and tests could not be run — proxy.golang.org is blocked in this environment (pre-existing infrastructure limitation). The changes are syntactically verified by inspection:

• All callers of removed functions have been updated or removed
• No remaining references to deprecated names in production code or tests
• The rename is a mechanical sed-replace with no logic changes

Closes #7136

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• proxy.golang.org
• releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by Repo Assist · sonnet46 8M · ◷

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55

[Copilot]

Pull request overview

This PR continues the Agent ID terminology migration by removing deprecated “API key” alias wrapper functions that were left behind for backwards compatibility, and by renaming the remaining generator helper to the Agent ID name to reduce IDE/autocomplete confusion.

Changes:

• Removed deprecated alias wrappers: ValidateAPIKey, (*Config).GetAPIKey, and GetGatewayAPIKeyFromEnv.
• Renamed GenerateRandomAPIKey() → GenerateRandomAgentID() and updated the single production call site plus tests.
• Updated a stale doc comment reference from ValidateAPIKey() to ValidateAgentID().

Show a summary per file

File	Description
internal/auth/header.go	Removes deprecated validation alias and renames random generator to GenerateRandomAgentID.
internal/auth/header_test.go	Deletes the alias-only test for ValidateAPIKey.
internal/auth/apikey_test.go	Renames tests and call sites to GenerateRandomAgentID.
internal/cmd/root.go	Updates the production caller to use GenerateRandomAgentID.
internal/config/config_core.go	Removes deprecated GetAPIKey() accessor alias.
internal/config/config_env.go	Removes deprecated GetGatewayAPIKeyFromEnv() alias.
internal/server/middleware.go	Updates comment to reference the new validation function name.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 7/7 changed files
• Comments generated: 1

[lpcox]

@copilot address review feedback

[Copilot]

@copilot address review feedback

Addressed in commit 02c89e1: updated the authMiddleware doc comment to reference the helpers actually used (ParseAuthHeader and IsMalformedHeader) and clarified that credential validation is done via direct comparison in the middleware.