[log] Add debug logging to HTTP server lifecycle in serve.go#7123
Merged
Conversation
Add 5 meaningful debug log calls to the serveAndWait function using the existing package-level debugLog logger. These log server startup, unexpected exits, shutdown signal receipt, graceful shutdown failures, and successful graceful shutdown — all key lifecycle events that aid in troubleshooting server startup and shutdown behaviour. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves debuggability of the gateway’s HTTP server lifecycle by adding debugLog statements to serveAndWait (internal/cmd/serve.go), which is used as the shared serve/shutdown helper for gateway startup and proxy mode.
Changes:
- Add a debug log at
serveAndWaitentry with server address and shutdown timeout. - Add debug logs for unexpected server exit (triggering cancellation) and for the shutdown path (start, shutdown failure with forced close, graceful completion).
Show a summary per file
| File | Description |
|---|---|
| internal/cmd/serve.go | Adds debug-level visibility into core HTTP server start/stop lifecycle within serveAndWait. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 5 meaningful
debugLogcalls toserveAndWaitininternal/cmd/serve.go, covering key HTTP server lifecycle events:Starting HTTP server: addr=%s, shutdownTimeout=%sHTTP server exited unexpectedly, triggering shutdown: %vserveFnbefore context is cancelledShutdown signal received, beginning graceful HTTP server shutdownGraceful shutdown failed, forcing close: %vhttpServer.Shutdown()returned an errorHTTP server shut down gracefullyWhy this file?
serveAndWaitis the core server lifecycle helper called fromroot.gofor every gateway startup. It orchestrates background serving, signal handling, graceful shutdown, and error propagation — but had zero debug visibility. These logs help diagnose startup failures and shutdown timing issues.Implementation notes
debugLog = logger.New("cmd:root")declared inroot.go— no new logger or import neededhttpServer.Addr,timeout,err)make test-allgreen; Rust guard failure is a pre-existing network sandbox limitation)Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
index.crates.ioSee Network Configuration for more information.