feat(cli): add --enable-dind flag to opt-in to Docker socket access#1276
Merged
feat(cli): add --enable-dind flag to opt-in to Docker socket access#1276
Conversation
Add --enable-dind flag that exposes the host Docker socket to the agent container, enabling Docker-in-Docker workflows. By default, the socket remains hidden (mounted as /dev/null) for security. Closes #116 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in CLI/config switch to allow Docker-in-Docker style workflows by exposing the host Docker socket to the agent container, while keeping the default behavior secure (socket hidden via /dev/null).
Changes:
- Extend
WrapperConfigwithenableDind?: boolean. - Update Docker Compose generation to either hide or expose the host Docker socket based on
enableDind. - Add CLI flag
--enable-dindand unit tests covering default/opt-in behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/types.ts |
Adds enableDind config field with security warning docs. |
src/docker-manager.ts |
Gates Docker socket volume mounts on config.enableDind. |
src/docker-manager.test.ts |
Adds unit coverage for default hide vs opt-in expose behavior. |
src/cli.ts |
Adds --enable-dind flag and wires it into WrapperConfig. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+392
to
+399
| * When true, the host's Docker socket (/var/run/docker.sock) is mounted | ||
| * into the agent container, allowing the agent to run Docker commands. | ||
| * | ||
| * WARNING: This allows the agent to bypass firewall restrictions by | ||
| * spawning new containers without network restrictions. | ||
| * | ||
| * @default false | ||
| */ |
Comment on lines
+728
to
+730
| agentVolumes.push(`${dockerSocketPath}:/host${dockerSocketPath}:rw`); | ||
| // Also expose the /run/docker.sock symlink if it exists | ||
| agentVolumes.push('/run/docker.sock:/host/run/docker.sock:rw'); |
Comment on lines
+689
to
+701
| it('should expose Docker socket when enableDind is true', () => { | ||
| const dindConfig = { ...mockConfig, enableDind: true }; | ||
| const result = generateDockerCompose(dindConfig, mockNetworkConfig); | ||
| const agent = result.services.agent; | ||
| const volumes = agent.volumes as string[]; | ||
|
|
||
| // Docker socket should be mounted read-write, not hidden | ||
| expect(volumes).toContain('/var/run/docker.sock:/host/var/run/docker.sock:rw'); | ||
| expect(volumes).toContain('/run/docker.sock:/host/run/docker.sock:rw'); | ||
| // Should NOT have /dev/null mounts | ||
| expect(volumes).not.toContain('/dev/null:/host/var/run/docker.sock:ro'); | ||
| expect(volumes).not.toContain('/dev/null:/host/run/docker.sock:ro'); | ||
| }); |
Contributor
Smoke Test Results — PASS ✅
Overall: PASS —
|
Contributor
Smoke Test Results
Overall: PASS
|
Contributor
Chroot Version Comparison Results
Result: FAILED — Python and Node.js versions differ between host and chroot environments.
|
Contributor
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--enable-dindCLI flag that exposes the host Docker socket to the agent container/dev/null) for security/var/run/docker.sockand/run/docker.sockas read-write into the chrootFixes #116
Test plan
should hide Docker socket by default)enableDind: true(should expose Docker socket when enableDind is true)🤖 Generated with Claude Code