Repository navigation
Conversation
Add opt-in strict GetTablets discovery with verified TLS, explicit endpoint selection and no HTTP fallback. Preserve legacy HTTP discovery and isolate request timeouts. Update the Go builders and regenerate vendor for the supported schema and patched gRPC transport. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical issues leave builds on an unsupported Go toolchain, break deployment artifact and glibc compatibility, and reject Go 1.27 before compilation.
3 open issues
What changed in this PR
Adds opt-in gRPC tablet discovery for newer Vitess releases while retaining legacy HTTP discovery.
Changes:
- Connects discovery transport selection and configuration validation, with per-call HTTP deadlines.
- Updates Go builders, packaging checks, and deployment guidance.
- Refreshes vendored Vitess, gRPC, protobuf, and transitive dependencies.
| File | Description |
|---|---|
| vendor/vitess.io/vitess/go/vt/proto/vttime/cached_size.go | Updated as part of this pull request. |
| vendor/vitess.io/vitess/go/hack/runtime.s | Updated as part of this pull request. |
| vendor/vitess.io/vitess/go/hack/hack.go | Updated as part of this pull request. |
| vendor/vitess.io/vitess/go/hack/compat.go | Updated as part of this pull request. |
| vendor/gopkg.in/yaml.v3/NOTICE | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/runtime/protoiface/legacy.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/protoadapt/convert.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/proto/wrappers.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/proto/reset.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/proto/proto.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/proto/proto_reflect.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/proto/proto_methods.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/PATENTS | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/LICENSE | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/protolazy/pointer_unsafe.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/pragma/pragma.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/impl/pointer_unsafe_opaque.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/impl/enum.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/impl/codec_unsafe.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/impl/bitmap.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/wrappers.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/timestamp_gen.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/source_context_gen.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/name.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/map_entry.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/goname.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/field_mask_gen.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/empty_gen.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/duration_gen.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/doc.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/genid/any_gen.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/flags/proto_legacy_enable.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/flags/proto_legacy_disable.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/flags/flags.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/filedesc/presence.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/encoding/text/doc.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/editiondefaults/defaults.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/internal/descopts/options.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/encoding/prototext/doc.go | Updated as part of this pull request. |
| vendor/google.golang.org/protobuf/encoding/protojson/doc.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/version.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/trace_withtrace.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/serviceconfig/serviceconfig.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/SECURITY.md | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/NOTICE.txt | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/Makefile | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/transport/readyreader/raw_conn_nonlinux.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/transport/readyreader/raw_conn_linux.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/transport/networktype/networktype.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/transport/logging.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/transport/internal/internal.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/tcp_keepalive_others.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/grpcutil/metadata.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/grpcutil/grpcutil.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/grpcutil/compressor.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/experimental.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/envconfig/observability.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/credentials/credentials.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/channelz/syscall_nonlinux.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/internal/balancerload/load.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/grpclog/logger.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/grpclog/internal/grpclog.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/GOVERNANCE.md | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/encoding/internal/internal.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/doc.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/CODE-OF-CONDUCT.md | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/clientconn_disconnect_reason_plan9.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/clientconn_disconnect_reason_noplan9.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/channelz/channelz.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/balancer/pickfirst/internal/internal.go | Updated as part of this pull request. |
| vendor/google.golang.org/grpc/AUTHORS | Updated as part of this pull request. |
| vendor/golang.org/x/text/unicode/bidi/trieval.go | Updated as part of this pull request. |
| vendor/golang.org/x/text/PATENTS | Updated as part of this pull request. |
| vendor/golang.org/x/text/LICENSE | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/types_windows_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/types_windows_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/types_windows_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/types_windows_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/str.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/race0.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/race.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/mksyscall.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/eventlog.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/windows/aliases.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_solaris_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_openbsd_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_openbsd_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_openbsd_mips64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_openbsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_openbsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_freebsd_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_freebsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_freebsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_freebsd_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_freebsd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_dragonfly_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_aix_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ztypes_aix_ppc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_openbsd_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_openbsd_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_openbsd_mips64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_openbsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_openbsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_openbsd_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_openbsd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_netbsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_netbsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_netbsd_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_netbsd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_s390x.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64le.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_ppc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_mipsle.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_mips64le.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_mips64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_mips.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_linux_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_freebsd_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_freebsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_freebsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_freebsd_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_freebsd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_dragonfly_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_darwin_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysnum_darwin_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysctl_openbsd_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsysctl_openbsd_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zsyscall_linux_loong64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zptrace_linux_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_solaris_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_openbsd_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_openbsd_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_netbsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_netbsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_netbsd_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_netbsd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_freebsd_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_freebsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_freebsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_freebsd_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_freebsd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_dragonfly_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_aix_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/zerrors_aix_ppc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/xattr_bsd.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/vgetrandom_unsupported.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/vgetrandom_linux.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/timestruct.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/sysvshm_unix.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/sysvshm_unix_other.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/sysvshm_linux.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_unix_gc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_unix_gc_ppc64x.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_solaris_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_openbsd_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_openbsd_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_openbsd_libc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_openbsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_openbsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_openbsd_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_openbsd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_netbsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_netbsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_netbsd_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_netbsd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_sparc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_s390x.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_ppc64x.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_mips64x.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_gccgo_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_gccgo_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_gc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_gc_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_gc_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_amd64_gc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_linux_alarm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_illumos.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_hurd.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_hurd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_freebsd_riscv64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_freebsd_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_freebsd_arm.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_freebsd_386.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_dragonfly_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_darwin_libSystem.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_darwin_arm64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_darwin_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_aix_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/syscall_aix_ppc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/sockcmsg_unix.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/sockcmsg_unix_other.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/README.md | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/readdirent_getdirentries.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/readdirent_getdents.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/race0.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/race.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ptrace_ios.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ptrace_darwin.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/pagesize_unix.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/mmap_nomremap.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/mkall.sh | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/ifreq_linux.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/gccgo.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/gccgo_linux_amd64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/gccgo_c.c | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/fdset.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/fcntl.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/fcntl_linux_32bit.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/env_unix.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/endian_little.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/endian_big.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/dirent.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/dev_zos.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/dev_aix_ppc64.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/dev_aix_ppc.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/constants.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/cap_freebsd.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/auxv.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/auxv_unsupported.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_solaris_amd64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_openbsd_mips64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_s390x.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_riscv64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_ppc64x.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_mipsx.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_mips64x.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_loong64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_arm64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_arm.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_amd64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_linux_386.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_bsd_riscv64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_bsd_ppc64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_bsd_arm64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_bsd_arm.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_bsd_amd64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_bsd_386.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/asm_aix_ppc64.s | Updated as part of this pull request. |
| vendor/golang.org/x/sys/unix/aliases.go | Updated as part of this pull request. |
| vendor/golang.org/x/sys/LICENSE | Updated as part of this pull request. |
| vendor/golang.org/x/net/PATENTS | Updated as part of this pull request. |
| vendor/golang.org/x/net/LICENSE | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/unencrypted.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/README.md | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/config_go126.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/config_go125.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/client_priority_go127.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/client_priority_go126.go | Updated as part of this pull request. |
| vendor/golang.org/x/net/http2/.gitignore | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/LICENSE | Updated as part of this pull request. |
| vendor/github.com/stretchr/testify/assert/forward_assertions.go | Updated as part of this pull request. |
| vendor/github.com/rcrowley/go-metrics/.travis.yml | Updated as part of this pull request. |
| vendor/github.com/planetscale/vtprotobuf/LICENSE | Updated as part of this pull request. |
| vendor/github.com/hashicorp/golang-lru/simplelru/lru_interface.go | Updated as part of this pull request. |
| vendor/github.com/hashicorp/golang-lru/LICENSE | Updated as part of this pull request. |
| vendor/github.com/hashicorp/go-immutable-radix/README.md | Updated as part of this pull request. |
| vendor/github.com/hashicorp/go-immutable-radix/raw_iter.go | Updated as part of this pull request. |
| vendor/github.com/hashicorp/go-immutable-radix/iradix.go | Updated as part of this pull request. |
| vendor/github.com/hashicorp/go-immutable-radix/CHANGELOG.md | Updated as part of this pull request. |
| vendor/github.com/hashicorp/go-immutable-radix/.travis.yml | Updated as part of this pull request. |
| vendor/github.com/golang/protobuf/CONTRIBUTORS | Updated as part of this pull request. |
| vendor/github.com/golang/protobuf/AUTHORS | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/transaction.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/statement.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/nulltime.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/nulltime_legacy.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/nulltime_go113.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/fuzz.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/errors.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/driver.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/const.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/conncheck.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/conncheck_dummy.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/collations.go | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/CHANGELOG.md | Updated as part of this pull request. |
| vendor/github.com/go-sql-driver/mysql/atomic_bool.go | Updated as part of this pull request. |
| vendor/github.com/davecgh/go-spew/spew/format.go | Updated as part of this pull request. |
| vendor/github.com/davecgh/go-spew/spew/dump.go | Updated as part of this pull request. |
| vendor/github.com/davecgh/go-spew/spew/common.go | Updated as part of this pull request. |
| vendor/github.com/davecgh/go-spew/spew/bypasssafe.go | Updated as part of this pull request. |
| vendor/github.com/davecgh/go-spew/LICENSE | Updated as part of this pull request. |
| vendor/github.com/armon/go-metrics/start.go | Updated as part of this pull request. |
| vendor/github.com/armon/go-metrics/sink.go | Updated as part of this pull request. |
| vendor/github.com/armon/go-metrics/.gitignore | Updated as part of this pull request. |
| script/bootstrap | Updated as part of this pull request. |
| README.md | Updated as part of this pull request. |
| pkg/vitess/api_client.go | Updated as part of this pull request. |
| pkg/vitess/api_client_test.go | Updated as part of this pull request. |
| pkg/throttle/throttler.go | Updated as part of this pull request. |
| pkg/config/mysql_config.go | Updated as part of this pull request. |
| Dockerfile.test | Updated as part of this pull request. |
| Dockerfile | Updated as part of this pull request. |
| build.sh | Updated as part of this pull request. |
Review effort: Max (auto)
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.16-alpine | |||
| FROM golang:1.25-alpine | |||
| @@ -1,11 +1,6 @@ | |||
| FROM golang:1.16-stretch | |||
| FROM golang:1.25-bookworm | |||
| set -e | ||
|
|
||
| readonly supportedGo="go1.2[012345]" | ||
| readonly supportedGo="go1\.2[56]" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit
VitessSettings.GRPCAddress(host:port), optionalGRPCCAFile/GRPCServerName, and explicit plaintext opt-inGRPCInsecure. ExistingKeyspace, optionalShard,Cells/ inheritedVitessCells, andTimeoutSecsapply to both transports; zero timeout remains five seconds. TLS options cannot be combined with plaintext mode. Discovery errors retain the previous inventory. HTTP timeouts are now per-call rather than mutable shared state.Uses the stable Vitess v0.21.0 generated client, not v23 client libraries. Updates and regenerates vendor, aligns container builders and packaging checks, and documents configuration and rollout requirements. The large diff is predominantly generated vendored code.
Evidence
After: native local gRPC-server tests pass for request filters, all-shard discovery, replica-only selection, MySQL address mapping, strict requests, RPC errors, deadlines, TLS verification failures, no HTTP fallback, connection closure, and concurrent HTTP/gRPC calls. Existing HTTP tests also pass.
GOTOOLCHAIN=go1.25.0 script/cibuild: build and all application race tests pass; Vitess package coverage is 95.7%.go vet ./pkg/...,go mod tidy -diff, andgo mod verifypass.--version;Dockerfile.testbuilds and runs the canonical checks successfully on Linux. The test image was built from a clean clone because a copied worktree.gitpointer is invalid inside a container.GetTabletsRequest/GetTabletsResponsedefinitions are byte-identical across v21.0.0, v22.0.0, and v23.0.8. Verified the RPC declaration and tablet alias/keyspace/shard/type/MySQL address wire fields as well. This is source and RPC-contract evidence, not real v22/v23 vtctld daemon integration testing.Merge Danger
Door: two-way
Existing
API-only configurations do not switch transports automatically. gRPC is explicit, never derives a port from HTTP, and never falls back to HTTP after an error. Reverting the source/configuration is possible without a data migration.Blast Radius: Discovery
Builders now require Go 1.25+ for gRPC v1.83.2, including current HTTP/2 memory-exhaustion fixes. The older v0.12.6 schema was evaluated but failed modern Go linking through its runtime helpers; v0.21.0 works without runtime-linker bypasses or manual vendor patches. Transitive dependency updates follow Go module selection and are covered by the existing build/race suite.
A runtime cutover still requires a reachable VtctldServer gRPC listener and matching TLS trust/name configuration. Client-certificate and authentication-metadata support is not added here, so mTLS-only endpoints are not ready for this client. gRPC returns topology records rather than HTTP realtime tablet-health snapshots; Freno retains its configured MySQL probes and HTTP checks. No live configuration, deployment, or merge is performed by this PR.