Github Actions: Clarify masking explanation in workflow-commands.md#44224
Open
mcummings128 wants to merge 1 commit intogithub:mainfrom
Open
Github Actions: Clarify masking explanation in workflow-commands.md#44224mcummings128 wants to merge 1 commit intogithub:mainfrom
mcummings128 wants to merge 1 commit intogithub:mainfrom
Conversation
Clarified that masking a value must be done once per value per job.
Contributor
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Closes: TBD
What's being changed (if available, include any code snippets, screenshots, or gifs):
In the Github Actions documentation Workflow commands for GitHub Actions: Masking A Value In A Log
This pull request clarifies that masking a value must be done once per value per job. This is not apparent enough in the documentation--while the warning is present, it doesn't specify this needs only to be done once per value per job, only that add-mask should be used with the value as soon as possible. Adding this sentence makes
add-maskbehavior more explicit and user-friendly.Check off the following: