Skip to content

Secret Scanning: Revise notes on validity and metadata checks#44222

Open
BasixKOR wants to merge 1 commit into
github:mainfrom
BasixKOR:patch-1
Open

Secret Scanning: Revise notes on validity and metadata checks#44222
BasixKOR wants to merge 1 commit into
github:mainfrom
BasixKOR:patch-1

Conversation

@BasixKOR
Copy link
Copy Markdown

@BasixKOR BasixKOR commented May 11, 2026 •
edited
Loading

Why:

The diff should be obvious.

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • Fixed the syntax on Note block to render correctly.
  • Removed the merge conflict marker.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@BasixKOR
Revise notes on validity and metadata checks
571b793 
Updated notes on validity checks and extended metadata support in the secret scanning patterns documentation.
Copilot AI review requested due to automatic review settings May 11, 2026 01:14
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
code-security/reference/secret-security/supported-secret-scanning-patterns.md fpt
ghec
ghes@ 3.20 3.19 3.18 3.17 3.16
fpt
ghec
ghes@ 3.20 3.19 3.18 3.17 3.16

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

Copilot AI reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Secret Scanning reference page to clean up previously broken Markdown around validity/metadata notes and to remove merge-conflict artifacts, improving readability and rendering consistency in the docs site.

Changes:

  • Adjusted the “Validity and extended metadata checks” note formatting near the capabilities table.
  • Removed leftover merge conflict markers around the provider patterns section header.

Comment thread content/code-security/reference/secret-security/supported-secret-scanning-patterns.md
| Base64 format support | {% octicon "x" aria-label="Not supported" %} | {% octicon "x" aria-label="Not supported" %} | Some |

>[! NOTE] Validity and extended metadata checks are only available to users with {% data variables.product.prodname_team %} or {% data variables.product.prodname_enterprise %} who enable the feature as part of {% data variables.product.prodname_GH_secret_protection %}.
>[!NOTE] Validity and extended metadata checks are only available to users with {% data variables.product.prodname_team %} or {% data variables.product.prodname_enterprise %} who enable the feature as part of {% data variables.product.prodname_GH_secret_protection %}.
Copy link
Copy Markdown
Author

@BasixKOR BasixKOR May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be fixed as other alerts within the same document is used without a line break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BasixKOR