TypeScript SDK: Use generated types for model info and remove duplicates#1564
Draft
sergiou87 wants to merge 1 commit into
Draft
TypeScript SDK: Use generated types for model info and remove duplicates#1564sergiou87 wants to merge 1 commit into
sergiou87 wants to merge 1 commit into
Conversation
Replace local duplicate model/session types with imports/exported types from generated files. Reorder imports, re-export model, remote session and session-fs related types, and export SessionEvent. Remove redundant local interfaces (ModelCapabilities, ModelInfo, ModelPolicy, ModelBilling) to centralize type definitions in generated/rpc and generated/session-events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace local duplicate model info types (which need to be manually updated) with types from generated files.
I tried this approach since I see the same pattern used for
SessionEventandRemoteSessionMode:copilot-sdk/nodejs/src/types.ts
Lines 12 to 21 in afbebc7