Skip to content

Fix MCP E2E send wait race #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Jun 2, 2026
+2 −6
Merged

Fix MCP E2E send wait race #1556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions dotnet/test/E2E/SessionMcpAndAgentConfigE2ETests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ public async Task Should_Accept_MCP_Server_Configuration_On_Session_Create()
await WaitForMcpServerStatusAsync(session, "test-server", McpServerStatus.Connected);

// Simple interaction to verify session works
await session.SendAsync(new MessageOptions { Prompt = "What is 2+2?" });

var message = await TestHelper.GetFinalAssistantMessageAsync(session);
var message = await session.SendAndWaitAsync(new MessageOptions { Prompt = "What is 2+2?" });
Assert.NotNull(message);
Assert.Contains("4", message!.Data.Content);

Expand Down Expand Up @@ -112,9 +110,7 @@ public async Task Should_Accept_Custom_Agent_Configuration_On_Session_Create()
Assert.Matches(@"^[a-f0-9-]+$", session.SessionId);

// Simple interaction to verify session works
await session.SendAsync(new MessageOptions { Prompt = "What is 5+5?" });

var message = await TestHelper.GetFinalAssistantMessageAsync(session);
var message = await session.SendAndWaitAsync(new MessageOptions { Prompt = "What is 5+5?" });
Assert.NotNull(message);
Assert.Contains("10", message!.Data.Content);

Expand Down
Loading