Revert temporary beta-as-latest publishing behavior#1551
Merged
Conversation
This reverts commit 4e3dc73.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the temporary “beta-as-latest” publishing behavior introduced in #1283, restoring the original release/publish semantics now that 1.0.0 is ready: latest becomes a true stable release flow again, while prerelease continues to publish prerelease builds.
Changes:
- Restores
latestversion calculation to patch increments and promotes higher prereleases (e.g.1.0.0-beta.N) to stable (1.0.0). - Re-enforces publish-time validation that
latestmust not include a prerelease suffix and routeslatestto a full GitHub Release (not a pre-release). - Updates Node tests to match the restored stable-promotion behavior.
Show a summary per file
| File | Description |
|---|---|
nodejs/scripts/calculate-version.js |
Switches latest back to patch increments and removes latest from prerelease identifier selection to enable stable promotion. |
nodejs/test/get-version.test.ts |
Updates expectations for latest patch bumping and prerelease-to-stable promotion. |
.github/workflows/publish.yml |
Restores stable-vs-prerelease validation for latest and splits GitHub Release vs Pre-Release creation by dist-tag. |
Copilot's findings
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:256
- Same issue as the stable release step: without fetching tags,
git rev-parseis unlikely to findv${{ needs.version.outputs.current-prerelease }}, so--notes-start-tagwon’t be used even when the tag exists remotely. Fetch tags before performing the existence check.
NOTES_FLAG=""
if git rev-parse "v${{ needs.version.outputs.current-prerelease }}" >/dev/null 2>&1; then
NOTES_FLAG="--notes-start-tag v${{ needs.version.outputs.current-prerelease }}"
fi
- Files reviewed: 3/3 changed files
- Comments generated: 1
Comment on lines
+240
to
+243
| NOTES_FLAG="" | ||
| if git rev-parse "v${{ needs.version.outputs.current }}" >/dev/null 2>&1; then | ||
| NOTES_FLAG="--notes-start-tag v${{ needs.version.outputs.current }}" | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1283 (commit 4e3dc73) which temporarily routed the
latestdist-tag through the prerelease pipeline so we could publish1.0.0-beta.*underlatest.With
1.0.0ready to ship, restore the original publish behavior:publish.yml: re-enforce thatlatestrequires a non-prerelease version, and routelatesttoCreate GitHub Release(real release) whileprereleasecontinues to produce a Pre-Release.calculate-version.js:latestincrements bypatchagain, and a higher prerelease (e.g.1.0.0-beta.N) gets promoted to stable (1.0.0).get-version.test.ts: the two(temporary beta behavior)tests revert to their original stable-promotion assertions.Revert applied cleanly with no conflicts; no other commits since #1283 touched these regions.