Skip to content

Remove obsolete fmt and rules_dotnet registry versions - #23029

Merged
jketema merged 1 commit into
mainfrom
jketema-remove-old-bazel-csharp-fmt
Nov 5, 2026
Merged

jketema merged 1 commit into
mainfrom
jketema-remove-old-bazel-csharp-fmt

Conversation

@jketema

@jketema jketema commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Remove the old patched Bazel registry entries for fmt 12.1.0-codeql.1 and rules_dotnet 0.21.5-codeql.1, and regenerate their version metadata. The current module versions, fmt 12.2.0.bcr.1-codeql.1 and rules_dotnet 0.22.2-codeql.1, are retained.

Drop fmt 12.1.0-codeql.1 and rules_dotnet 0.21.5-codeql.1 now that consumers use the newer patched versions. Regenerate registry metadata to list only the retained versions.
@jketema
jketema marked this pull request as ready for review November 5, 2026 13:43
@jketema
jketema requested review from a team as code owners November 5, 2026 13:43
@jketema
jketema requested review from michaelnebel and an auto review from Copilot November 5, 2026 13:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the changes consistently remove only the obsolete CodeQL-patched versions and their associated metadata while retaining current versions.

No open issues 🎉

What changed in this PR

Removes obsolete CodeQL-patched Bazel registry versions for fmt and rules_dotnet, retaining the current versions and regenerating their metadata.

Changes:

  • Removes fmt version 12.1.0-codeql.1 and its overlays and source metadata.
  • Removes rules_dotnet version 0.21.5-codeql.1 and its patch and source metadata.
  • Updates both module metadata files to list only the retained versions.
File Description
misc/​bazel/​registry/​modules/​rules_dotnet/​metadata.json Removes the obsolete version from registry metadata.
misc/​bazel/​registry/​modules/​rules_dotnet/​0.21.5-codeql.1/​source.json Removes obsolete source metadata.
misc/​bazel/​registry/​modules/​rules_dotnet/​0.21.5-codeql.1/​patches/​revert_additional_files_in_nuget_archive.patch Removes the obsolete patch.
misc/​bazel/​registry/​modules/​rules_dotnet/​0.21.5-codeql.1/​MODULE.bazel Removes the obsolete module definition.
misc/​bazel/​registry/​modules/​fmt/​metadata.json Removes the obsolete version from registry metadata.
misc/​bazel/​registry/​modules/​fmt/​12.1.0-codeql.1/​source.json Removes obsolete source metadata.
misc/​bazel/​registry/​modules/​fmt/​12.1.0-codeql.1/​overlay/​MODULE.bazel Removes the obsolete module overlay.
misc/​bazel/​registry/​modules/​fmt/​12.1.0-codeql.1/​overlay/​BUILD.bazel Removes the obsolete build overlay.
misc/​bazel/​registry/​modules/​fmt/​12.1.0-codeql.1/​MODULE.bazel Removes the obsolete module definition.

Review effort: Lite (auto)

@michaelnebel michaelnebel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jketema
jketema merged commit fb80308 into main Nov 5, 2026
82 checks passed
@jketema
jketema deleted the jketema-remove-old-bazel-csharp-fmt branch November 5, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants