Skip to content

C++: Allow forwarding to nested types forwards MaD models #23016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 3 commits into from
Nov 4, 2026
Merged

C++: Allow forwarding to nested types forwards MaD models #23016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f6f788
C++: Test nested typedefs in forwarding.
MathiasVP Oct 12, 2026
4018024
C++: Support typedef's in forward models.
MathiasVP Oct 22, 2026
da6b766
C++: Accept test changes.
MathiasVP Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,21 +1088,26 @@ private Type getForwardedConstructorType(
Function forwarder, string namespace, string type, boolean subtypes, string name,
string signature, string ext, string constructorType
) {
exists(int index |
forwardsModel(namespace, type, subtypes, name, signature, ext, _, constructorType, _, _, _) and
forwarder = interpretElement(namespace, type, subtypes, name, signature, ext)
|
exists(string typeArguments |
forwardsModel(namespace, type, subtypes, name, signature, ext, _, constructorType, _, _, _) and
forwarder = interpretElement(namespace, type, subtypes, name, signature, ext) and
(
exists(string typeArguments, int index |
parseAngles(type, _, typeArguments, "") and
constructorType = getAtIndex(typeArguments, index) and
result = forwarder.getDeclaringType().getTemplateArgument(index)
)
or
exists(string nameArguments |
exists(string nameArguments, int index |
parseAngles(name, _, nameArguments, "") and
constructorType = getAtIndex(nameArguments, index) and
result = forwarder.getTemplateArgument(index)
)
or
exists(TypedefType member |
member = forwarder.getDeclaringType().getAMember() and
Comment thread
MathiasVP marked this conversation as resolved.
Resolved
member.hasName(constructorType) and
result = member.getUnderlyingType()
)
)
}

Expand Down
Loading
Loading