C#: Add some logging messages for lazily computed sets of dependencies. - #22601
Draft
michaelnebel wants to merge 1 commit into
Draft
michaelnebel wants to merge 1 commit into
michaelnebel wants to merge 1 commit into
Conversation
michaelnebel
force-pushed
the
csharp/feedmanagerlogging
branch
from
September 17, 2026 11:24
d17a242 to
72d8db8
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The logging additions accurately describe existing lazy computations and introduce no functional changes.
Review effort: Balanced
Findings: None
What changed in this PR
Adds informational logging around lazy NuGet feed discovery without changing feed selection behavior.
Changes:
- Logs discovery of explicit, inherited, fallback, default, and aggregate feed sets.
- Preserves lazy evaluation.
| File | Description |
|---|---|
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs |
Adds feed-discovery log messages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
michaelnebel
added
the
no-change-note-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the FeedManager logging.