C#: Very basic support for .NET 11 RC1. - #22565
Open
michaelnebel wants to merge 2 commits into
Open
michaelnebel wants to merge 2 commits into
michaelnebel wants to merge 2 commits into
Conversation
michaelnebel
force-pushed
the
csharp/dotnetrc1test
branch
from
September 15, 2026 10:38
94d541f to
e103167
Compare
michaelnebel
changed the title
michaelnebel
force-pushed
the
csharp/dotnetrc1test
branch
2 times, most recently
from
September 15, 2026 12:09
9eed24a to
ab9e4de
Compare
michaelnebel
force-pushed
the
csharp/dotnetrc1test
branch
from
September 15, 2026 12:10
ab9e4de to
8386853
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review tier: Lite (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Lite.
What changed in this PR
Adds basic .NET 11 RC1 support for C# extraction, including a Windows installer workaround and integration coverage.
Changes:
- Forces ZIP-based .NET installation on Windows.
- Adds traced and buildless .NET 11 integration tests.
- Adds a minimal .NET 11 console project fixture.
| File | Description |
|---|---|
csharp/ql/integration-tests/all-platforms/dotnet_11/test.py |
Tests traced and buildless extraction. |
csharp/ql/integration-tests/all-platforms/dotnet_11/Program.cs |
Provides the test application. |
csharp/ql/integration-tests/all-platforms/dotnet_11/global.json |
Pins the .NET 11 RC1 SDK. |
csharp/ql/integration-tests/all-platforms/dotnet_11/dotnet_build.csproj |
Targets net11.0. |
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DotNet.cs |
Configures the Windows installer workaround. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
michaelnebel
added
the
no-change-note-required
michaelnebel
marked this pull request as ready for review
September 15, 2026 12:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that some new logic has been introduced in the powershell script for installing
dotnet. For .NET 11 and onwards the scripts prefers to download thetar.gzarchive ofdotnet. However, this causes the script to fail when unpacking the archive (at least on our Windows runners). The logic can be seen here.The
.ziparchive is still available and we can force the script to download the.zipfile instead by settingDOTNET_INSTALL_SKIP_TAR.In this PR we
DOTNET_INSTALL_SKIP_TAR=1when installing a specific version ofdotneton Windows runners.build-mode: noneextraction using .NET 11.