Skip to content

Rust: Update supported-frameworks.rst and add a few more native-tls models - #22382

Merged
geoffw0 merged 10 commits into
github:mainfrom
geoffw0:nativetls
Sep 30, 2026
Merged

geoffw0 merged 10 commits into
github:mainfrom
geoffw0:nativetls

Conversation

@geoffw0

@geoffw0 geoffw0 commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

I spotted some gaps in supported-frameworks.rst, which motivated (via a Copilot suggestion) a few model improvements as well:

  • axum is supported (sources + sinks).
  • native-tls and async-native-tls are supported (sinks).
  • in the latter case I added a couple of new models for better coverage.
  • update: and then some test cases, to verify the coverage.

@geoffw0 geoffw0 added the Rust Pull requests that update Rust code label Aug 19, 2026
Copilot AI balanced review requested due to automatic review settings August 19, 2026 13:10
@geoffw0
geoffw0 requested review from a team as code owners August 19, 2026 13:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Rust framework documentation and expands TLS taint-flow modeling.

Changes:

  • Documents Axum and native TLS crates.
  • Adds native, async-native, and Tokio-native TLS summaries.
  • Adds synchronous native-tls flow coverage.
Show a summary per file
File Description
test.rs Adds native-tls flow test.
TaintSources.expected Updates source expectations.
options.yml Adds native-tls dependency.
InlineFlow.expected Updates flow expectations.
Cargo.lock Records direct dependency.
native-tls.model.yml Adds TLS summaries.
Change note Announces analysis improvements.
supported-frameworks.rst Documents supported Rust crates.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 7/8 changed files
  • Comments generated: 3
  • Review effort level: Balanced

Comment thread rust/ql/lib/codeql/rust/frameworks/native-tls.model.yml Outdated
Comment thread rust/ql/lib/codeql/rust/frameworks/native-tls.model.yml
Comment thread rust/ql/lib/codeql/rust/frameworks/native-tls.model.yml

@paldepind paldepind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One questions, otherwise LGTM!

Comment thread rust/ql/test/library-tests/dataflow/sources/net/test.rs Outdated
@geoffw0

geoffw0 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Ready for re-approval.

@paldepind paldepind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geoffw0

geoffw0 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Thanks!

@geoffw0
geoffw0 merged commit 4841ad5 into github:main Sep 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants