Draft
Conversation
Uses the `DuckTyping` module to approximate whether something is likely to be an iterator or not. We lose one test result due to the fact that we don't know what to do about `for ... in 1` (because `1` is an instance of a built-in). I'm going to defer addressing this until we get some modelling of built-in types.
A common pattern is to check `isinstance(it, (list, tuple))` before proceeding with the iteration.
tausbn
force-pushed
the
tausbn/python-port-non-iterator-in-for-loop
branch
from
9ad28d0 to
8fdf5c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the
DuckTypingmodule to approximate whether something is likelyto be an iterator or not.
We lose one test result due to the fact that we don't know what to do
about
for ... in 1(because1is an instance of a built-in). I'mgoing to defer addressing this until we get some modelling of built-in
types.