Rust: Replace recursion through forall with ranked recursion#21679
Draft
hvitved wants to merge 3 commits intogithub:mainfrom
Draft
Rust: Replace recursion through forall with ranked recursion#21679hvitved wants to merge 3 commits intogithub:mainfrom
forall with ranked recursion#21679hvitved wants to merge 3 commits intogithub:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
rust/type-inference-forall-checks
branch
from
27f8658 to
5c6c3c0
Compare
hvitved
force-pushed
the
rust/type-inference-forall-checks
branch
4 times, most recently
from
1888e7a to
ad0a58f
Compare
hvitved
force-pushed
the
rust/type-inference-forall-checks
branch
from
ad0a58f to
e7930fe
Compare
hvitved
force-pushed
the
rust/type-inference-forall-checks
branch
from
e7930fe to
27f7f74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent QA run showed a timeout on
mimuw-distributed-systems-group/cmemu. The problematic predicate washasNoCompatibleTargetNoBorrowToIndex, where we do recursion throughforallvia the inlined predicatehasNoCompatibleNonBlanketTargetCheck. This PR applies the standard trick of replacing such recursion with ranked recursion, and since the original check already happened inside such (another) ranked recursion, it means we are now doing two levels ranked recursion (see QL doc on the newly introducedNoCompatibleTargetmodule).I also noted that in the original
hasNoCompatibleTargetSharedBorrowcheck we were callinghasNoCompatibleNonBlanketLikeTargetCheck, which should have beenhasNoCompatibleTargetCheck(just like inhasNoCompatibleTargetNoBorrow), so this has been fixed as well.The second commit is an unrelated improvement to how we check blanket constraints.