Rust: Improve TuplePositionContent.getAnAccess
#21099
Merged
+2
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the TuplePositionContent.getAnAccess predicate by properly limiting field accesses to actual tuple types, addressing a TODO comment. The change eliminates spurious data flow steps that were previously generated for tuple struct field accesses.
Key Changes:
- Fixed the
getAnAccess()implementation to properly filter by tuple types instead of matching any numeric field identifier - Updated comment to correctly reference
TuplePositionContentinstead ofTupleContent
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/dataflow/internal/Content.qll | Replaces overly broad field access matching with proper tuple type filtering; fixes comment typo |
| rust/ql/test/library-tests/dataflow/local/DataFlowStep.expected | Removes spurious readStep entries with invalid file locations that were incorrectly generated |
| rust/ql/test/library-tests/dataflow/collections/inline-flow.expected | Removes spurious edges, nodes, and subpaths entries with tuple.0 content that were incorrectly generated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the TODO in that predicate.
DCA is uneventful.