Java: Replace SSA wrapper classes with shared implementation. #20761
Conversation
aschackmull
force-pushed
the
java/ssa-shared
branch
from
e54b277 to
cf8d1bd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| import java | ||
| private import internal.SsaImpl | ||
| import internal.SsaImpl::Ssa as Ssa |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
| } | ||
|
|
||
| private predicate upcastEnhancedForStmtAux(BaseSsaUpdate v, RefType t, RefType t1, RefType t2) { | ||
| private predicate upcastEnhancedForStmtAux( |
Check warning
Code scanning / CodeQL
Candidate predicate not marked as `nomagic` Warning
| i = 0 | ||
| ) | ||
| } | ||
| module Ssa = Impl::MakeSsa<SsaInput>; |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
| } | ||
| } | ||
|
|
||
| module Ssa = Impl::MakeSsa<SsaInput>; |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
aschackmull
force-pushed
the
java/ssa-shared
branch
6 times, most recently
from
aad896a to
cb33a68
Compare
|
I've left several deprecation annotations for a followup PR to avoid having to do a submodule bump here. |
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the SSA (Static Single Assignment) API for Java CodeQL by renaming classes and methods to improve clarity and consistency. The changes deprecate old class and method names while introducing clearer alternatives.
- Renames core SSA classes (e.g.,
SsaVariable→SsaDefinition,SsaPhiNode→SsaPhiDefinition) - Renames methods for consistency (e.g.,
getAUse()→getARead(),getCfgNode()→getControlFlowNode()) - Introduces new specialized SSA classes with clearer semantics (
SsaCapturedDefinition,SsaImplicitCallDefinition, etc.)
Reviewed Changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/ssa/codeql/ssa/Ssa.qll | Adds toString methods and renames SsaPhiDefinition class definition |
| java/ql/lib/semmle/code/java/dataflow/SSA.qll | Core SSA API with renamed classes and deprecated old names |
| java/ql/lib/semmle/code/java/dataflow/internal/BaseSSA.qll | Base SSA implementation updated with new class names |
| java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll | Internal SSA implementation restructuring |
| java/ql/test/**/*.ql | Test queries updated to use new API |
| java/ql/test/**/*.expected | Generated test expectations updated with new toString formats |
| java/ql/lib/**/*.qll | Various library files updated to use new API |
| java/ql/src/**/*.qll | Source queries updated to use new API |
| java/ql/lib/semmle/code/java/Expr.qll | Adds new VariableWrite class for SSA integration |
| java/ql/lib/change-notes/2025-10-07-ssa-api-updates.md | Documents the deprecation of old SSA API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ger tracked as SSA variables.
aschackmull
force-pushed
the
java/ssa-shared
branch
from
3a30e2a to
4a58a01
Compare
1 participant
This migrates the Java SSA libraries to use the shared SSA wrapper classes.
Commit-by-commit review is very much encouraged.