JS: Fix semantic merge conflict: Implement new signature members in StepInputSig #18513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- javascript/ql/lib/semmle/javascript/dataflow/internal/FlowSummaryPrivate.qll: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
erik-krogh
approved these changes
Jan 16, 2025
hvitved
reviewed
Jan 16, 2025
| */ | ||
| class SummarizedCallableBase = string; | ||
|
|
||
| class SourceBase extends Unit { |
Contributor
There was a problem hiding this comment.
Alternatively, you can use the Void type from codeql.util.Void.
Contributor
Author
There was a problem hiding this comment.
Will do next time. In this case I'd rather unbreak main asap.
Contributor
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a semantic merge conflict between #18467 and #18298