Repository navigation
Remove macos-14-xlarge from codeql workflow - #4309
Open
henrymercer wants to merge 1 commit into
Open
henrymercer wants to merge 1 commit into
henrymercer wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Although the workflow diff is straightforward, safe merging requires removing both macos-14 matrix contexts from external branch-protection required checks, which cannot be verified from the checked-in files.
No open issues 🎉
What changed in this PR
Removes the unsupported macos-14-xlarge runner from the CodeQL JavaScript analysis matrix, preventing required merge-queue checks from failing.
Changes:
- Removes
macos-14-xlargefrom theanalyze-javascriptoperating-system matrix. - Retains Ubuntu, Windows, and
macos-15-xlargecoverage. - Required-check configuration must be synchronized separately.
| File | Description |
|---|---|
.github/workflows/codeql.yml |
Removes the unsupported macOS 14 runner from the CodeQL analysis matrix. |
Review effort: Lite (auto)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
analyze-javascript (macos-14-xlarge)jobs in thecodeqlworkflow are now cancelled with "The configuration 'macos-14-arm64-us-xl' is not supported". These are required checks, so every PR in the merge queue is failing. This PR removesmacos-14-xlargewithout a replacement, since many other PR checks already run on macOS 26. A follow-up PR will look at the overall PR check coverage across runner images.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
pr-checks/sync-checks.tsbefore it can merge. The release branches will pick up the workflow change in the next release, as they did for Removemacos-13fromcodeqlworkflow #3274.Merge / deployment checklist