Revert "feat: add support for deployment "task" and multi-deployments for a given environment" #431
+312
−3,730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for a given environment"
Copilot finished reviewing on behalf of
GrantBirki
November 26, 2025 19:25
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the feature that added support for deployment "task" and multi-deployments for a given environment (PR #410). The revert removes the ability to handle concurrent deployments to the same environment using task identifiers.
Key Changes
- Removed
unlock-on-closemode functionality and the entireunlock-on-close.jsfile - Removed
deployment_taskinput parameter and related validation logic - Removed
taskparameter from lock, unlock, deployment, and environment-targeting functions - Simplified lock ownership checking to only verify user (removed branch/PR-specific checks)
- Removed test files and test cases related to task functionality
- Updated the bundled
dist/index.jsto reflect all source changes
Reviewed changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.js | Removed unlock-on-close mode, task validation logic, and task parameters from function calls |
| src/functions/lock.js | Removed task support from lock branch naming, lock file creation, and ownership checking |
| src/functions/unlock.js | Removed task parsing from unlock commands and branch name construction |
| src/functions/unlock-on-merge.js | Simplified to only handle single lock per environment (no task-based locks) |
| src/functions/unlock-on-close.js | Entire file deleted |
| src/functions/deployment.js | Removed task filtering from deployment queries |
| src/functions/valid-deployment-order.js | Removed task parameter from function signature |
| src/functions/post-deploy.js | Removed task parameter from lock/unlock function calls |
| src/functions/inputs.js | Removed deployment_task input processing |
| src/functions/environment-targets.js | Removed task parsing from command body |
| action.yml | Removed unlock_on_close_mode and deployment_task inputs/outputs |
| tests/* | Removed all task-related test cases and the unlock-on-close test file |
| dist/index.js | Updated bundle to reflect all source changes |
| } | ||
|
|
||
| // If it is a lock or lock info related request | ||
| // If it is a lock or lock info releated request |
There was a problem hiding this comment.
Typo in comment: "releated" should be "related".
Suggested change
| // If it is a lock or lock info releated request | |
| // If it is a lock or lock info related request |
| // Use the 'sticky' flag to determine whether the lock is sticky or not | ||
| // Sticky locks will persist forever unless the 'unlock on merge' mode is being utilized | ||
| // non-sticky locks are temporary and only exist during the deployment process to prevent other deployments... | ||
| // non-sticky locks are tempory and only exist during the deployment process to prevent other deployments... |
There was a problem hiding this comment.
Typo in comment: "tempory" should be "temporary".
Suggested change
| // non-sticky locks are tempory and only exist during the deployment process to prevent other deployments... | |
| // non-sticky locks are temporary and only exist during the deployment process to prevent other deployments... |
| // :param task: The deployment task to lock (if any) | ||
| // :param issue_number: The number of the issue being processed | ||
| // :returns: A lock response object | ||
| // :returns: A lock repsponse object |
There was a problem hiding this comment.
Typo in comment: "repsponse" should be "response".
Suggested change
| // :returns: A lock repsponse object | |
| // :returns: A lock response object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #410