Skip to content

new skill typescript-coder#898

Open
jhauga wants to merge 9 commits intogithub:stagedfrom
jhauga:skill-typescript-coder
Open

new skill typescript-coder#898
jhauga wants to merge 9 commits intogithub:stagedfrom
jhauga:skill-typescript-coder

Conversation

@jhauga
Copy link
Contributor

@jhauga jhauga commented Mar 6, 2026

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • My contribution adds a new instruction, prompt, agent, skill, or workflow file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, or workflow with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.

Description

For full test results ctrl + click support-repo.

Most of the reference files use code examples from w3schools.com. They state in their terms of service that permitted use includes Copying examples and code snippets for non-profit teaching or research, and given that this repo has an MIT license; so non-profit, and it seems these work as a teaching tool, then no problem. The takeaway I get from their terms of use is - don't copy our content and make a competing website.

  • Agent: Local
  • Model: Claude Sonnet 4.5
  • Number of Prompts: 1
  • Post Edits: added 1 line:
    • <link href="favicon.png" rel="icon">

Prompt

ts-coder --create web-application 
         --project-scope worlds-most-cliche-type-safe-web-app 
         --use-library react 
         --run-in-browser=true 
         --create-pages [home(index.html), contact.html] 
         --page home="generic form to order parts from a manufacturer" 
         --page contact="generic form to contact customer support" 
         --app-hosting GitHubPages

Results

Good results:

  • Functional form
  • Throws error on missing required fields
  • Throws errors on invalid fields

I think this could be configured and plugged into a server after adding production elements.


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • Update to existing instruction, prompt, agent, plugin, skill, or workflow.
  • Other (please specify):

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

@jhauga jhauga requested a review from aaronpowell as a code owner March 6, 2026 01:26
Copilot AI review requested due to automatic review settings March 6, 2026 01:26
@jhauga jhauga marked this pull request as draft March 6, 2026 01:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new TypeScript Coder skill to the skills catalog, bundling TypeScript guidance and reference material intended for Copilot-assisted TypeScript adoption and migration tasks.

Changes:

  • Added new skill definition at skills/typescript-coder/SKILL.md describing when/how to use the skill and common workflows.
  • Added a set of bundled TypeScript reference documents under skills/typescript-coder/references/.
  • Registered the new skill in docs/README.skills.md.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
skills/typescript-coder/SKILL.md New skill definition, usage guidance, and reference index.
skills/typescript-coder/references/typescript-basics.md Basics/reference content for TypeScript fundamentals and inference.
skills/typescript-coder/references/typescript-cheatsheet.md Cheatsheet-style reference content (control flow, classes, interfaces, types).
skills/typescript-coder/references/typescript-classes.md Reference content for classes, generics, and utility types.
skills/typescript-coder/references/typescript-elements.md Reference content for arrays/tuples/objects/enums/functions/casting.
skills/typescript-coder/references/typescript-handbook.md Handbook-style reference based on official TS docs concepts.
skills/typescript-coder/references/typescript-keywords.md Reference content for keyof, null/undefined, DefinitelyTyped, TS 5.x notes.
skills/typescript-coder/references/typescript-miscellaneous.md Reference content for async, decorators, JSDoc, migration, error handling, etc.
skills/typescript-coder/references/typescript-projects.md Reference content for tsconfig, Node/React setup, tooling, testing examples.
skills/typescript-coder/references/typescript-types.md Reference content for advanced types (mapped/conditional/template literal, etc.).
docs/README.skills.md Adds the new typescript-coder entry to the skills index table.

jhauga and others added 3 commits March 5, 2026 21:26
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
My browsers' being buggy, but this should have been committed with the last batch of commits.
@jhauga jhauga marked this pull request as ready for review March 6, 2026 02:33
Copy link
Contributor

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that w3schools would be the best resource to point people to, why not use the TypeScript website? That way there's confidence that the most up to date content is available to the agent as it works.

Also, there might be some plugins that this would be useful to include with

@jhauga jhauga marked this pull request as draft March 6, 2026 04:48
@jhauga jhauga requested a review from Copilot March 7, 2026 00:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 55 changed files in this pull request and generated 5 comments.

Comment on lines +65 to +66
// We have no type safety in our tuple for indexes 3+
ourTuple.push('Something new and wrong');
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section header suggests this is about readonly tuples, but the first example is a mutable tuple and discusses push(). Also, the statement “no type safety for indexes 3+” is at least misleading in modern TypeScript (tuple push is typed, and extra indices don’t become safely known). Consider renaming/restructuring the section (e.g., split into “Tuple mutation / push behavior” vs “Readonly tuples”) and clarify what is and isn’t type-safe.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jhauga jhauga marked this pull request as ready for review March 7, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants