Skip to content

fix: implement semantic string-to-bool normalization in cli.py (#1466)#1623

Open
NehaGitHubAcc wants to merge 1 commit intogithub:stagedfrom
NehaGitHubAcc:fix/string-to-bool-normalization
Open

fix: implement semantic string-to-bool normalization in cli.py (#1466)#1623
NehaGitHubAcc wants to merge 1 commit intogithub:stagedfrom
NehaGitHubAcc:fix/string-to-bool-normalization

Conversation

@NehaGitHubAcc
Copy link
Copy Markdown

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, or workflow file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, or workflow with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the staged branch for this pull request.

Description

This PR fixes issue #1466 where the string "false" was being evaluated as True due to standard Python bool() casting.

I have implemented a normalization check that explicitly checks for truthy/falsy strings (e.g., "true", "false", "1", "0") and added a warning log for invalid inputs to prevent silent failures.

Fixes #1466


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • Update to existing instruction, prompt, agent, plugin, skill, or workflow.
  • [] Other (please specify):

Additional Notes


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

@NehaGitHubAcc NehaGitHubAcc requested a review from aaronpowell as a code owner May 5, 2026 10:41
@github-actions github-actions Bot added the skills PR touches skills label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🔍 Skill Validator Results

⚠️ Warnings or advisories found

Scope Checked
Skills 1
Agents 1
Total 2
Severity Count
--- ---:
❌ Errors 0
⚠️ Warnings 1
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ Found 1 skill(s)
ℹ️ [azure-architecture-autopilot] 📊 azure-architecture-autopilot: 1,758 BPE tokens [chars/4: 1,830] (detailed ✓), 16 sections, 5 code blocks
ℹ️ [azure-architecture-autopilot] ⚠ No numbered workflow steps — agents follow sequenced procedures more reliably.
ℹ️ ✅ All checks passed (1 skill(s))
Full validator output ```text Found 1 skill(s) [azure-architecture-autopilot] 📊 azure-architecture-autopilot: 1,758 BPE tokens [chars/4: 1,830] (detailed ✓), 16 sections, 5 code blocks [azure-architecture-autopilot] ⚠ No numbered workflow steps — agents follow sequenced procedures more reliably. ✅ All checks passed (1 skill(s)) ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant